-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify authors. #206
Clarify authors. #206
Conversation
README.md
Outdated
|
||
## Contributors | ||
|
||
Yorick is developed by the Software Development Team at King's College London, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can be more inclusive here. Maybe something like "Yorick is developed by a team of people which can be seen in the ." I don't think we need a special mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 12d05fc
Please squash. |
All Cargo manifests now list "The Yorick Developers" and we provide a link to the Github contributors page in the README.
splat. |
bors r+ |
Build failed: |
bors try |
tryBuild failed: |
bors r+ |
Build failed: |
I wonder if the upstream sync broke it. Maybe cargo is installed in a
different location or something.
I'll look into it when I find a moment.
…On Tue, 22 Dec 2020, 09:36 Laurence Tratt, ***@***.***> wrote:
cargo not being found is a bit odd! Let's try again.
bors r+
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#206 (comment)>, or
unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AAETWGYLMFGER6MKVYETMTLSWBSBTANCNFSM4VEJWGHA>
.
|
Made a little progress with this. Something seems to have changed with
I also notice something wrong with the CI snapshot directory:
My guess there is that the removal of Out of time for now :) |
Aha, OK! |
I've been slowly investigating this. It seems the installer is currently in flux, and this is likely the source of our problems: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/.60x.2Epy.20install.60.20broken.3F |
It looks like there's a PR fix up now? rust-lang/rust#80514 |
Once that's merged, I'll sync upstream and hopefully it will fix our
issues. We actually saw a different problem, but I'm hoping it's related.
I'm also going to add CI steps that check that certain binaries exist in
the install dir, like cargo and rustc. Then we can catch this kind of thing
earlier next time.
…On Wed, 30 Dec 2020, 19:11 Laurence Tratt, ***@***.***> wrote:
It looks like there's a PR fix up now? rust-lang/rust#80514
<rust-lang/rust#80514>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#206 (comment)>, or
unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AAETWG7MNCOIGIQJKIHHJV3SXN3NLANCNFSM4VEJWGHA>
.
|
I've checked and rust-lang/rust#80514 has been merged into rust's master branch, even though the PR is still open. So I think we're good to go! |
Using this morning's upstream master, |
Ye gods :/ |
bors try |
tryBuild succeeded: |
@ltratt this is good to go. |
Do you want/need to rebase against master? |
It's already up to date, so we can go ahead. |
bors r+ |
Build succeeded: |
The main change is 3fbad79, then there's a commit to make the README overview better.