Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused braces from html! macro #2167

Closed
wants to merge 2 commits into from

Conversation

ranile
Copy link
Member

@ranile ranile commented Nov 21, 2021

Description

Remove unused braces from the macro's generated code.

Fixes #2157

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

voidpumpkin
voidpumpkin previously approved these changes Nov 21, 2021
@Madoshakalaka
Copy link
Contributor

removing the braces causes the #[allow(clippy::unit_arg)] to be applied to an expression, which is an unstable feature.
I think the change is not trivial and I have worked out a different version. Will submit a PR in a moment!

@ranile
Copy link
Member Author

ranile commented Nov 21, 2021

removing the braces causes the #[allow(clippy::unit_arg)] to be applied to an expression, which is an unstable feature. I think the change is not trivial and I have worked out a different version. Will submit a PR in a moment!

Ah, I see. I'll fix it in this PR.

@ranile
Copy link
Member Author

ranile commented Nov 21, 2021

Nevermind, my fix didn't work. @Madoshakalaka if you wanna try, go ahead.

@ranile ranile closed this Nov 21, 2021
@ranile ranile deleted the html-nested-braces branch November 21, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html_nested! inserts extra pair of brackets
3 participants