writeData() force evaluation of x before options are set
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 66.36% 66.37%
=======================================
Files 34 34
Lines 8965 8966 +1
=======================================
+ Hits 5950 5951 +1
Misses 3015 3015
Continue to review full report at Codecov.
|
jmbarbone
changed the title
writeData() force evaluation of x before options are set
JanMarvin
reviewed
Sep 30, 2021
| out <- read.xlsx(wbfile) | ||
|
|
||
| # Possibly overkill | ||
|
|
JanMarvin
reviewed
Sep 30, 2021
NEWS.md
Outdated
| @@ -9,12 +9,11 @@ | |||
| * add option to save as read only recommended ([#201](/~https://github.com/ychps/openxlsx/issues/201)) | |||
| * fixed writing hyperlink formulas ([#200](/~https://github.com/ychps/openxlsx/issues/200)) | |||
| * `write.xlsx()` now throws an error if it doesn't have write permissions ([#190](/~https://github.com/ycphs/openxlsx/issues/190)) | |||
| * `write.xlsx()` now again uses the default of `overwrite = TRUE` for saving files ([#249](/~https://github.com/ycphs/openxlsx/issues/249)) | |||
There was a problem hiding this comment.
why did you remove this?
There was a problem hiding this comment.
By mistake probably. Didn't notice this.
|
Thanks, simple and elegant! LGTM! |
JanMarvin
approved these changes
Sep 30, 2021
|
could you please rebase on/or merge with master? |
|
merged in d2f7e03 , thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply using
force(x)before options seems to do the trick.No local test fails.
resolves #264