Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symfony 6 support #19

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Add symfony 6 support #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6083e7
Add symfony 6 compatibility, dropping 4
janlam7 Jun 6, 2024
3369398
Allow php:^8.1
janlam7 Jun 6, 2024
28a2f07
Add twig 3 compatibility, dropping 2
janlam7 Jun 6, 2024
827db6f
Update unit tests
janlam7 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
php-versions: ['7.3', '7.4', '8.0']
php-versions: ['8.1','8.2','8.3']
name: PHP ${{ matrix.php-versions }}
steps:
- uses: actions/checkout@v2
Expand Down
18 changes: 9 additions & 9 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@
}
],
"require": {
"php": "^7.3|^8.0",
"symfony/config": "^4.2||^5.0",
"symfony/dependency-injection": "^4.2||^5.0",
"symfony/finder": "^4.2||^5.0",
"symfony/framework-bundle": "^4.2||^5.0",
"symfony/http-kernel": "^4.2||^5.0"
"php": "^8.1",
"symfony/config": "^5.4||^6.0",
"symfony/dependency-injection": "^5.4||^6.0",
"symfony/finder": "^5.4||^6.0",
"symfony/framework-bundle": "^5.4||^6.0",
"symfony/http-kernel": "^5.4||^6.0"
},
"require-dev": {
"phpspec/prophecy-phpunit": "^2.0",
"phpunit/phpunit": "^9.5.8",
"symfony/twig-bundle": "^4.2||^5.0",
"symfony/yaml": "^4.2||^5.0",
"twig/twig": "^2.12.1"
"symfony/twig-bundle": "^5.4||^6.0",
"symfony/yaml": "^5.4||^6.0",
"twig/twig": "^3.4.3"
},
"suggest": {
"twig/twig": "Allows use of features in twig templates through the FeaturesExtension"
Expand Down
4 changes: 2 additions & 2 deletions test/Functional/ConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ protected function setUp(): void

public function testFeatures(): void
{
$container = static::$kernel->getContainer();
$container = self::getContainer();
$features = $container->get(FeatureContainer::class);

// check if all the feature services are correcly configured
Expand Down Expand Up @@ -57,7 +57,7 @@ public function testFeatures(): void

public function testTwigFeature(): void
{
$container = static::$kernel->getContainer();
$container = self::getContainer();

self::assertEquals(
"feature is off",
Expand Down
1 change: 1 addition & 0 deletions test/Functional/Fixtures/config/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ services:

framework:
secret: test
test: true

twig:
debug: '%kernel.debug%'
Expand Down
Loading