Skip to content

Commit

Permalink
Add symfony 6 support (#19)
Browse files Browse the repository at this point in the history
* Add symfony 6 compatibility, dropping 4

* Allow php:^8.1

* Add twig 3 compatibility, dropping 2

* Update unit tests
  • Loading branch information
janlam7 authored Jun 6, 2024
1 parent db98dde commit 4e6bcb0
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
php-versions: ['7.3', '7.4', '8.0']
php-versions: ['8.1','8.2','8.3']
name: PHP ${{ matrix.php-versions }}
steps:
- uses: actions/checkout@v2
Expand Down
18 changes: 9 additions & 9 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@
}
],
"require": {
"php": "^7.3|^8.0",
"symfony/config": "^4.2||^5.0",
"symfony/dependency-injection": "^4.2||^5.0",
"symfony/finder": "^4.2||^5.0",
"symfony/framework-bundle": "^4.2||^5.0",
"symfony/http-kernel": "^4.2||^5.0"
"php": "^8.1",
"symfony/config": "^5.4||^6.0",
"symfony/dependency-injection": "^5.4||^6.0",
"symfony/finder": "^5.4||^6.0",
"symfony/framework-bundle": "^5.4||^6.0",
"symfony/http-kernel": "^5.4||^6.0"
},
"require-dev": {
"phpspec/prophecy-phpunit": "^2.0",
"phpunit/phpunit": "^9.5.8",
"symfony/twig-bundle": "^4.2||^5.0",
"symfony/yaml": "^4.2||^5.0",
"twig/twig": "^2.12.1"
"symfony/twig-bundle": "^5.4||^6.0",
"symfony/yaml": "^5.4||^6.0",
"twig/twig": "^3.4.3"
},
"suggest": {
"twig/twig": "Allows use of features in twig templates through the FeaturesExtension"
Expand Down
4 changes: 2 additions & 2 deletions test/Functional/ConfigurationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ protected function setUp(): void

public function testFeatures(): void
{
$container = static::$kernel->getContainer();
$container = self::getContainer();
$features = $container->get(FeatureContainer::class);

// check if all the feature services are correcly configured
Expand Down Expand Up @@ -57,7 +57,7 @@ public function testFeatures(): void

public function testTwigFeature(): void
{
$container = static::$kernel->getContainer();
$container = self::getContainer();

self::assertEquals(
"feature is off",
Expand Down
1 change: 1 addition & 0 deletions test/Functional/Fixtures/config/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ services:

framework:
secret: test
test: true

twig:
debug: '%kernel.debug%'
Expand Down

0 comments on commit 4e6bcb0

Please sign in to comment.