Merge pull request #45 from xyctruth/develop

Default query all target label
xyctruth · Feb 8, 2022 · 0a03ee3 · 0a03ee3
2 parents 0527f64 + 63685ce
commit 0a03ee3
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/pkg/storage/badger/func.go b/pkg/storage/badger/func.go
@@ -20,7 +20,7 @@ var (
 	PrefixIndex       = []byte{0x86}
 )
 
-// 内置label
+// TargetLabel 内置label
 const TargetLabel = "_target"
 
 func deletePrefixKey(key []byte) string {

diff --git a/pkg/storage/badger/store.go b/pkg/storage/badger/store.go
@@ -155,6 +155,19 @@ func (s *store) SaveProfileMeta(metas []*storage.ProfileMeta, ttl time.Duration)
 func (s *store) ListProfileMeta(sampleType string, startTime, endTime time.Time, filters ...storage.LabelFilter) ([]*storage.ProfileMetaByTarget, error) {
 	var err error
 
+	// Default query all target label
+	if len(filters) == 0 {
+		labels, err := s.ListLabel()
+		if err != nil {
+			return nil, err
+		}
+		for _, label := range labels {
+			if label.Key == TargetLabel {
+				filters = append(filters, storage.LabelFilter{Label: label})
+			}
+		}
+	}
+
 	ids, err := s.searchProfileMeta(sampleType, filters, startTime, endTime)
 	if err != nil {
 		return nil, err

diff --git a/pkg/storage/badger/store_test.go b/pkg/storage/badger/store_test.go
@@ -183,6 +183,10 @@ func TestProfileMeta(t *testing.T) {
 	require.Equal(t, nil, err)
 	require.Equal(t, 1, len(profileMetas))
 
+	profileMetasNoFilters, err := s.ListProfileMeta(sampleTypes[0], min, max)
+	require.Equal(t, nil, err)
+	require.Equal(t, 1, len(profileMetasNoFilters))
+
 	// Waiting for the overdue
 	time.Sleep(2 * time.Second)