Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write to lConn even if some error met and some bytes was read #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiquidTheDangerous
Copy link
Collaborator

Fixed potential issue when reading data from stream, got EOF. Write data from buffer if there is any

@LiquidTheDangerous LiquidTheDangerous changed the title fix: write to lConn even if io.EOF met and some bytes was read fix: write to lConn even if some error met and some bytes was read Sep 19, 2024
@LiquidTheDangerous
Copy link
Collaborator Author

In my case everything works without fix. Need someone to check for someone who doesn't work

@xvzc
Copy link
Owner

xvzc commented Sep 19, 2024

I will check this tomorrow i'm on a vacation now sorry

@LiquidTheDangerous
Copy link
Collaborator Author

LiquidTheDangerous commented Sep 19, 2024

According to reviews in #249, #252 there is no effect

@xvzc
Copy link
Owner

xvzc commented Sep 21, 2024

Shouldn't we do the same thing for proxy/hanlder/http.go?

@LiquidTheDangerous
Copy link
Collaborator Author

@xvzc It seems there is no point in reworking. Everything works for me without this fix. For people for whom YouTube does not work now, both with and without the fix do not work

@LunarLorkhan
Copy link

It does not work for me

Ventura 13.6.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants