Changes for week of Jan13 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
force-pushed
the
Jan13
branch
3 times, most recently
from
b80df6a to
40a6612
Compare
jskeet
approved these changes
Jan 16, 2025
core/spec.md
Outdated
| The `?nested` semantics MUST be applied to all nested `COLLECTIONS` attributes | ||
| within the request regardless of the level in the hierarchy in which they | ||
| appear. | ||
| If `COLLECTIONS` attribute is present, the server MUST process each entity in |
There was a problem hiding this comment.
I'd have either
If
COLLECTIONSattributes are present
or
If the
COLLECTIONSattribute is present
The singular with no article feels a bit odd.
core/spec.md
Outdated
| Resource when exported will adhere to the following: | ||
| #### Compact | ||
|
|
||
| The "compact" query parameter (flag) MAY be used to indicate that the response |
There was a problem hiding this comment.
Suggested change
| The "compact" query parameter (flag) MAY be used to indicate that the response | |
| The `?compact` query parameter (flag) MAY be used to indicate that the response |
(Just for consistency with filter.)
- typo and wording clarifications in main spec
- remove duplicate "compatibility" in schema, it's part of core attributes now
- replaced `?export` with `?compact` and just removes the dup info. Any
inlining would need to be requested by the client
- defined `/export` to be `/?compact&inline=*,model,capabilities`
- remove ?nested
- tweaks valid chars for ID: `[a-zA-Z0-9_][a-zA-Z0-9_.\-~@]{0,127}`
- IDs must be no longer than 128 chars
- s/$structure/$details/g
Fixes: xregistry#234
Fixes: xregistry#233
Fixes: xregistry#232
Fixes: xregistry#220
Fixes: xregistry#229
Fixes: xregistry#224
Fixes: xregistry#237
Signed-off-by: Doug Davis <duglin@gmail.com>
|
Approved on the 1/16 call - thanks @jskeet for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?exportwith?compactand just removes the dup info. Anyinlining would need to be requested by the client
/exportto be/?compact&inline=*,model,capabilities[a-zA-Z0-9_][a-zA-Z0-9_.\-~@]{0,127}Fixes: #234
Fixes: #233
Fixes: #232
Fixes: #220
Fixes: #229
Fixes: #224
Fixes: #237