Detect pin name clashes #1356
Merged
Detect pin name clashes #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Jul 12, 2018
There was a problem hiding this comment.
Kudos for the refactoring ➕
Minus for attention 😛
It’s important to check normalized pin labels to make sure the scenarios when an input takes an auto-generated name IN3 and manually named output IN3 are not possible.
Try to put an input pulse and an output pulse. Give the output label IN. It should cause the error, but it is not.
packages/xod-project/src/project.js
Outdated
| * @param {Project} project | ||
| * @returns {Either<Error|Patch>} | ||
| */ | ||
| // TODO: Try to simplify this mess :-D |
There was a problem hiding this comment.
You’ve simplified the mess 👍 I think this comment should go.
packages/xod-project/src/messages.js
Outdated
| CLASHING_PIN_LABELS: ({ label, pinKeys, trace }) => ({ | ||
| title: 'Clashing pin names', | ||
| note: `${pinKeys.length} pins are named ${label}`, | ||
| solution: 'Give pins unique names', |
|
Done. |
evgenykochetkov
force-pushed
the
fix-1337-detect-pin-name-clashes
branch
from
1a3d1f4 to
a630e79
Compare
1 task
evgenykochetkov
force-pushed
the
fix-1337-detect-pin-name-clashes
branch
from
a630e79 to
4966ff7
Compare
…tches and nodes that cause errors themselves
…labels, rename to normalizeEmptyPinLabels
evgenykochetkov
force-pushed
the
fix-1337-detect-pin-name-clashes
branch
from
4966ff7 to
37d3b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1337
Plus a tiny bit of refactoring in
xod-client'sprojectselectors.