Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add XF86WLAN special key #921

Merged
merged 3 commits into from
Jan 18, 2025
Merged

add XF86WLAN special key #921

merged 3 commits into from
Jan 18, 2025

Conversation

geekosaur
Copy link
Contributor

Description

Add XF86WLAN to EZConfig.
Closes #27.

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: manually

  • I updated the CHANGES.md file (next push)

@geekosaur
Copy link
Contributor Author

@slotThe, OrgMode test failure only on 8.6.5, looks like a QuickCheck version problem possibly?

@slotThe
Copy link
Member

slotThe commented Jan 12, 2025

@slotThe, OrgMode test failure only on 8.6.5, looks like a QuickCheck version problem possibly?

Yes, it seems to pick 2.7.x, while arbitraryPrintableChar is only available from 2.10.x onwards. I'm curious, though, why this has never happened before?

@geekosaur
Copy link
Contributor Author

Betting some dependency changed its bounds, possibly by removing its own 8.6 support.

@slotThe
Copy link
Member

slotThe commented Jan 12, 2025

Debian stable already seems to be on 9.0… Should we just drop support for 8.6? (not because arbitraryPrintableChar is so difficult to define ourselves, but just as a matter of principle)

@liskin any opinions?

@liskin
Copy link
Member

liskin commented Jan 12, 2025

Debian stable already seems to be on 9.0… Should we just drop support for 8.6? (not because arbitraryPrintableChar is so difficult to define ourselves, but just as a matter of principle)

@liskin any opinions?

Yeah that's reasonable. Ubuntu 22.04, which seems to still be used quite a lot, has ghc 8.8.4, so we may want to keep that one.

Or not, I dunno. We're currently supporting (and testing against in CI!) 9 different major GHC versions, which seems quite excessive. It'd be 10 once the PRs adding 9.12 are merged (only looked at those briefly, some work needs to be done, and I'm kind of in the middle of doing that work for X11 and X11-xft). Just removing 8.6 gets us down to 9. Probably all right, we're far from running out of GitHub Actions budget :-)

slotThe added a commit to geekosaur/xmonad-contrib that referenced this pull request Jan 18, 2025
Copy link
Member

@slotThe slotThe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did this right. Should be good to go now

@geekosaur
Copy link
Contributor Author

LGTM

@geekosaur geekosaur merged commit 1f13bb2 into xmonad:master Jan 18, 2025
17 checks passed
geekosaur pushed a commit that referenced this pull request Jan 18, 2025
@geekosaur geekosaur deleted the ez-wlan branch January 18, 2025 16:45
@@ -12,10 +12,6 @@ jobs:
fail-fast: false
matrix:
include:
- resolver: lts-14 # GHC 8.6
yaml: stack.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was here to make sure we test compatibility with the latest hackage release of xmonad and X11 on both oldest and newest supported GHC. So only one of these should be dropped, and the stack.yaml one should be moved to a newer resolver.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that was what that was :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've added a comment really. It's a small miracle I still remember what the point was. Perhaps I don't and what I said isn't even true 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me from inspecting both the stack.yaml files. (I'm reminded of the stuff I added to cabal's CI to do much the same thing, but it's a little more involved since of course they don't build with stack.)

geekosaur added a commit to geekosaur/xmonad-contrib that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XMonad.Util.EZConfig] Function key XF86WLAN missing
3 participants