Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 프로젝트의 기본 폰트를 Spoqa Han Sans Neo로 설정 #47

Merged
merged 3 commits into from
Jul 23, 2024
Merged

[FE] 프로젝트의 기본 폰트를 Spoqa Han Sans Neo로 설정 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
023b052
feat: Spoqa Han Sans Neo 폰트 추가 (woff2)
Yoonkyoungme Jul 22, 2024
a36d133
design: font-face 정의 추가
Yoonkyoungme Jul 22, 2024
ae3a348
fix: 웹팩 폰트 로딩 경로 수정
Yoonkyoungme Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed frontend/src/assets/.gitkeep
View file
Open in desktop
Empty file.
Binary file added frontend/src/assets/fonts/SpoqaHanSansNeo-Bold.woff2
View file
Open in desktop
Binary file not shown.
Binary file added frontend/src/assets/fonts/SpoqaHanSansNeo-Light.woff2
View file
Open in desktop
Binary file not shown.
Binary file added frontend/src/assets/fonts/SpoqaHanSansNeo-Medium.woff2
View file
Open in desktop
Binary file not shown.
Binary file added frontend/src/assets/fonts/SpoqaHanSansNeo-Regular.woff2
View file
Open in desktop
Binary file not shown.
Binary file added frontend/src/assets/fonts/SpoqaHanSansNeo-Thin.woff2
View file
Open in desktop
Binary file not shown.
33 changes: 33 additions & 0 deletions frontend/src/styles/fonts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { css } from '@emotion/react';

export const fontFaces = css`
@font-face {
font-family: 'Spoqa Han Sans Neo';
font-weight: 100;
src: url(${require('../assets/fonts/SpoqaHanSansNeo-Thin.woff2')}) format('woff2');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전에 프로젝트에서 웹 폰트를 적용했을 때 저희와 같은 문제가 발생했었는데 문자열을 인식하지 못해서 생겼던 것이였군요...😭

빙봉 덕분에 꿀팁 알아갑니다~

}

@font-face {
font-family: 'Spoqa Han Sans Neo';
font-weight: 300;
src: url(${require('../assets/fonts/SpoqaHanSansNeo-Light.woff2')}) format('woff2');
}

@font-face {
font-family: 'Spoqa Han Sans Neo';
font-weight: 400;
src: url(${require('../assets/fonts/SpoqaHanSansNeo-Regular.woff2')}) format('woff2');
}

@font-face {
font-family: 'Spoqa Han Sans Neo';
font-weight: 500;
src: url(${require('../assets/fonts/SpoqaHanSansNeo-Medium.woff2')}) format('woff2');
}

@font-face {
font-family: 'Spoqa Han Sans Neo';
font-weight: 700;
src: url(${require('../assets/fonts/SpoqaHanSansNeo-Bold.woff2')}) format('woff2');
}
`;
5 changes: 5 additions & 0 deletions frontend/src/styles/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import { css } from '@emotion/react';

import { fontFaces } from './fonts';

const globalStyles = css`
${fontFaces}

html,
body,
div,
Expand Down Expand Up @@ -102,6 +106,7 @@ const globalStyles = css`
width: 100%;
min-height: 100vh;

font-family: 'Spoqa Han Sans Neo', sans-serif;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q]
제 육안상으로 확인했을 때, sans-serif를 붙였을 때와 붙이지 않았을 때의 차이가 없어 보이는데 뒤에 붙여주신 이유가 있을까요?!

Copy link
Contributor Author

@Yoonkyoungme Yoonkyoungme Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sans-serif를 font-family 속성에 추가한 이유는 Spoqa Han Sans Neo 폰트가 로드되지 않거나 사용할 수 없는 경우를 대비한 대체 폰트로 지정하기 위함입니다.

  font-family: 'Spoqa Han Sans Neo', sans-serif;

위 코드에서 브라우저는 먼저 Spoqa Han Sans Neo 폰트를 시도하고, 만약 이 폰트를 사용할 수 없다면 시스템의 기본 sans-serif 폰트를 사용합니다. 이를 통해 폰트 로딩 실패나 폰트가 없는 환경에서도 텍스트를 서비스에서 의도한대로 표시되도록 할 수 있습니다!

자세한 내용은 MDN 기본적인 텍스트 및 글꼴 스타일링 문서의 '글꼴 스택' 부분을 참고하면 좋습니다😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoqa Han Sans Neo 폰트를 사용할 수 없으면, 브라우저 기본 폰트를 사용한다고 하네요 :)
낙타랑 같은 의견으로 sans-serif 폰트를 명시하지 않아도 괜찮을 것 같습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

브라우저에서 Spoqua Han Sans Neo 글꼴 자체가 호환되지 않을 경우를 대비해서 sans-serif를 사용하신 것으로 이해했습니다! 좋아요 👍

Copy link
Contributor Author

@Yoonkyoungme Yoonkyoungme Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사파리 브라우저의 경우 기본으로 AppleMyungjo(명조체, serif)를 사용하고 있기 때문에
폰트를 설정해주지 않으면, 아래 사진처럼 보입니다.
우리 서비스에서 사용하는 폰트는 sans-serif 계열이기에 sans-serif를 명시해 두었습니다☺️
image

아래 글 내용이 너무 좋네요👏👏 시간 되실 때 읽어보는 거 추천합니다~~
https://velog.io/@seop/Safari사파리-에서-폰트가-이상하게-보일경우-해결법-CSS-font-family-속성-총정리

font-size: 1.6rem;

background-color: #6b6666;
Expand Down