Renamed procs/jobs to steps in code #1331

Harikesh00 · 2022-10-24T11:48:10Z

Renamed procs to steps in code for the issue #1288

Harikesh00 · 2022-10-24T11:54:35Z

@6543 plz review

…nto 1288-procs-steps

qwerty287

Two generic infos:

please add some migration information about what changed to the corresponding file in docs
you must add a DB migration that updates table / column names

.gitpod.yml

server/model/step.go

server/store/datastore/migration/000_legacy_to_xorm.go

server/store/datastore/migration/010_columns_rename_builds_to_pipeline.go

docs/versioned_docs/version-0.15/30-administration/00-setup.md

agent/runner.go

cli/exec/line.go

cli/pipeline/ps.go

cmd/agent/flags.go

pipeline/rpc/line.go

pipeline/tracer.go

server/model/file.go

server/store/datastore/migration/000_legacy_to_xorm.go

server/model/log.go

woodpecker-bot · 2022-10-24T15:04:43Z

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1331.surge.sh

qwerty287 · 2022-10-26T05:42:18Z

Depending on the kind of breaking change. If it affects database table/columm names, you're done with a migration. Otherwise it either will be breaking (depending on how important it is that's fine too, but then add a notice to the docs in the migrations file) or you should add a fallback.

Harikesh00 · 2022-10-26T16:46:54Z

ok, adding migration script and keeping the changes related to migration (wherever commented need migration)
let's review, if any issues, will resolve them based on the comments
and don't know what will be the fallback

Harikesh00 · 2022-10-26T17:27:16Z

@qwerty287 @6543 migration script added & review comments resolved
plz review

Harikesh00 · 2022-10-26T17:29:25Z

I didn't get what fallback means, why it's required and what it will do
can u plz explain

qwerty287 · 2022-10-26T17:55:34Z

If you just change an environment variable, it will break most users config. So we add a fallback to the old variable name (or whatever else has been breaking) to still be usable with older configs. I can look a bit more into this PR and fix some remaining stuff.

qwerty287 · 2022-10-26T18:11:00Z

@6543

With dff5e9e, I introduced some breaking (like JSON) changes again. Is this fine? We did that with build -> pipeline as well.

qwerty287 · 2022-10-26T18:35:47Z

I pushed various commits that finish renaming and fixes existing stuff. @6543 Probably you'll still find something we have to improve, but I don't really see much more.

codecov-commenter · 2022-10-26T19:50:44Z

Codecov Report

Base: 44.71% // Head: 44.89% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (91a09fc) compared to base (da7d13a).
Patch coverage: 47.20% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1331      +/-   ##
==========================================
+ Coverage   44.71%   44.89%   +0.17%     
==========================================
  Files         137      138       +1     
  Lines        9873     9941      +68     
==========================================
+ Hits         4415     4463      +48     
- Misses       5196     5213      +17     
- Partials      262      265       +3

Impacted Files	Coverage Δ
cmd/agent/agent.go	`0.00% <0.00%> (ø)`
pipeline/backend/docker/convert.go	`8.73% <0.00%> (ø)`
pipeline/backend/docker/docker.go	`0.00% <0.00%> (ø)`
pipeline/frontend/yaml/compiler/convert.go	`0.00% <0.00%> (ø)`
pipeline/logger.go	`0.00% <ø> (ø)`
pipeline/rpc/client_grpc.go	`0.00% <0.00%> (ø)`
pipeline/tracer.go	`0.00% <0.00%> (ø)`
server/grpc/rpc.go	`0.00% <0.00%> (ø)`
server/grpc/server.go	`0.00% <0.00%> (ø)`
server/model/file.go	`0.00% <ø> (ø)`
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/agent/flags.go

docs/docs/92-awesome.md

pipeline/tracer.go

server/store/datastore/migration/011_columns_rename_procs_to_steps.go

Co-authored-by: 6543 <6543@obermui.de>

cmd/agent/flags.go

web/web.go

server/shared/stepStatus.go

server/shared/stepStatus_test.go

qwerty287 · 2022-10-29T06:05:31Z

Thanks @Harikesh00 for the initial work on this.

6543 · 2022-10-29T12:16:44Z

☝️

Harikesh00 · 2022-11-02T17:44:58Z

Thank you @6543 @qwerty287 for all your support, you did a lot

Renamed `procs` to `steps` in code for the issue woodpecker-ci#1288 Co-authored-by: Harikesh Prajapati <harikesh.prajapati@druva.com> Co-authored-by: qwerty287 <ndev@web.de> Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com> Co-authored-by: 6543 <6543@obermui.de>

renamed procs to steps in code

1c398ed

Harikesh00 changed the title ~~Renamed procs to steps in code #1288~~ Renamed procs to steps in code Oct 24, 2022

Harikesh Prajapati added 2 commits October 24, 2022 17:26

renamed procs to steps in code

122f691

Merge branch '1288-procs-steps' of github.com:Harikesh00/woodpecker i…

dbba08d

…nto 1288-procs-steps

qwerty287 reviewed Oct 24, 2022

View reviewed changes

6543 requested changes Oct 24, 2022

View reviewed changes

6543 added the refactor delete or replace old code label Oct 24, 2022

qwerty287 added this to the 1.0.0 milestone Oct 24, 2022

This comment was marked as outdated.

Sign in to view

migration script added & few breaking changes reverted

8b94a5d

Merge branch 'master' into Harikesh00_1288-procs-steps

f31e646

Fix some more refactorings

dff5e9e

qwerty287 and others added 4 commits October 26, 2022 20:17

Merge branch 'master' into 1288-procs-steps

8a0bbba

Rename job -> step

36ac281

fix docs

0845688

Regenerate mocks + proto

eb6c4c6

Fix fmt

cbeeb1a

qwerty287 changed the title ~~Renamed procs to steps in code~~ Renamed procs/jobs to steps in code Oct 26, 2022

6543 reviewed Oct 27, 2022

View reviewed changes

cmd/agent/flags.go Outdated Show resolved Hide resolved

Merge branch 'master' into 1288-procs-steps

3bdfb31

6543 reviewed Oct 27, 2022

View reviewed changes

docs/docs/92-awesome.md Outdated Show resolved Hide resolved

6543 reviewed Oct 27, 2022

View reviewed changes

pipeline/tracer.go Show resolved Hide resolved

6543 reviewed Oct 27, 2022

View reviewed changes

server/store/datastore/migration/011_columns_rename_procs_to_steps.go Show resolved Hide resolved

qwerty287 and others added 4 commits October 27, 2022 18:08

Apply suggestions from code review

5940f46

Co-authored-by: 6543 <6543@obermui.de>

Merge migrations

a2d5857

Sort deprecated

e837dad

fix indent

3afe58b

6543 reviewed Oct 27, 2022

View reviewed changes

cmd/agent/flags.go Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

qwerty287 added 2 commits October 27, 2022 20:26

Rename to max-workflows

d1543db

Regenerate web components

a62f3f0

qwerty287 mentioned this pull request Oct 27, 2022

RFC: Establish some terminology #745

Closed

qwerty287 reviewed Oct 28, 2022

View reviewed changes

web/web.go Outdated Show resolved Hide resolved

qwerty287 and others added 2 commits October 28, 2022 12:24

Fix embed

695db49

Merge branch 'master' into 1288-procs-steps

e6029d4

qwerty287 mentioned this pull request Oct 28, 2022

Split server/shared #1355

Closed

qwerty287 and others added 2 commits October 28, 2022 13:17

Merge branch 'master' into 1288-procs-steps

7d9c87f

sort-too

a52384f

6543 reviewed Oct 28, 2022

View reviewed changes

server/shared/stepStatus.go Outdated Show resolved Hide resolved

6543 reviewed Oct 28, 2022

View reviewed changes

server/shared/stepStatus_test.go Outdated Show resolved Hide resolved

nit

91a09fc

6543 approved these changes Oct 28, 2022

View reviewed changes

6543 requested a review from qwerty287 October 28, 2022 13:43

qwerty287 approved these changes Oct 28, 2022

View reviewed changes

6543 merged commit 36e4291 into woodpecker-ci:master Oct 28, 2022

dvjn mentioned this pull request Oct 30, 2022

Broken Cancel Pipeline in Web UI and CLI #1369

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed procs/jobs to steps in code #1331

Renamed procs/jobs to steps in code #1331

Harikesh00 commented Oct 24, 2022 •

edited

Loading

Harikesh00 commented Oct 24, 2022

qwerty287 left a comment

woodpecker-bot commented Oct 24, 2022 •

edited

Loading

This comment was marked as outdated.

qwerty287 commented Oct 26, 2022

Harikesh00 commented Oct 26, 2022 •

edited

Loading

Harikesh00 commented Oct 26, 2022

Harikesh00 commented Oct 26, 2022

qwerty287 commented Oct 26, 2022

qwerty287 commented Oct 26, 2022

qwerty287 commented Oct 26, 2022

codecov-commenter commented Oct 26, 2022 •

edited

Loading

This comment was marked as outdated.

qwerty287 commented Oct 29, 2022

6543 commented Oct 29, 2022

Harikesh00 commented Nov 2, 2022

Renamed procs/jobs to steps in code #1331

Renamed procs/jobs to steps in code #1331

Conversation

Harikesh00 commented Oct 24, 2022 • edited Loading

Harikesh00 commented Oct 24, 2022

qwerty287 left a comment

Choose a reason for hiding this comment

woodpecker-bot commented Oct 24, 2022 • edited Loading

This comment was marked as outdated.

qwerty287 commented Oct 26, 2022

Harikesh00 commented Oct 26, 2022 • edited Loading

Harikesh00 commented Oct 26, 2022

Harikesh00 commented Oct 26, 2022

qwerty287 commented Oct 26, 2022

qwerty287 commented Oct 26, 2022

qwerty287 commented Oct 26, 2022

codecov-commenter commented Oct 26, 2022 • edited Loading

Codecov Report

This comment was marked as outdated.

qwerty287 commented Oct 29, 2022

6543 commented Oct 29, 2022

Harikesh00 commented Nov 2, 2022

Harikesh00 commented Oct 24, 2022 •

edited

Loading

woodpecker-bot commented Oct 24, 2022 •

edited

Loading

Harikesh00 commented Oct 26, 2022 •

edited

Loading

codecov-commenter commented Oct 26, 2022 •

edited

Loading