Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing tests check and update CONTRIBUTING.md #308

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

TahaTesser
Copy link
Collaborator

@TahaTesser TahaTesser commented Aug 19, 2024

Fixes Prepare repository for tests requirement

Description

  • Add a missing tests check will. comment on the PR if the tests are missing
  • Added melos command to run tests on the root and samples
  • Updated CONTRIBUTING.md for writing tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@TahaTesser TahaTesser changed the title Tests check Add a missing tests check and update CONTRIBUTING.md Aug 19, 2024
@TahaTesser TahaTesser force-pushed the tests_check branch 3 times, most recently from c222add to cba6653 Compare August 19, 2024 17:29
@TahaTesser
Copy link
Collaborator Author

"Check for Tests in PR / check-for-tests (pull_request) Failing after 8s" is failing due to permissions on a forked repo PR.
See actions/github-script#42 (comment)

It would work once the PR is merged. It works fine on my personal repository as seen here
image

Copy link
Collaborator

@ulusoyca ulusoyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. I will add this to our workflow at Wolt. :)

@TahaTesser TahaTesser merged commit 9fd6a72 into woltapp:main Aug 19, 2024
3 of 4 checks passed
@TahaTesser TahaTesser deleted the tests_check branch August 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare repository for tests requirement
2 participants