Skip to content

Commit

Permalink
+ set result viewer - exp, group, proj level
Browse files Browse the repository at this point in the history
+ Add notes saving: pickle, text, json

+ Proj methods make as Group methods (which is copying Box structure), and add them to API

+ Do TODO-s in the code
  + check exp is not active when changing its num or moving to another group
  + check exp is not active in other places
  + `get_active_experiments` for ExpProj and ExpGroup and their API - better use `filter_exps`

+ [!!!] Review destroy of active exp from active notebook (where pipeline was started) perspective and from passive notebook (just loaded the proj with active exp). Check that destroy from passive doesn't delete anything and brake active.

+ Rename `destroy_smth` in API methods because it seems like `destroy` method for GC

+ `filter_exps` from `XManAPI`, `XManProjAPI`, `XManGroupAPI` and their target classes should be implemented as a global filter system in `filter.py`.

+ change exp or group num

+ Move exp into another group

+ [!!!] Check all needed API methods exist in XManAPI
  + Implement checking system via pytest tests
  + Check and align

+ [!!!] Unlink result from the main data, move to `.result` - if someone put checkpoint into the result, it will be a cause of low performance. The same for manual result.

+ `result_viewer` rename to `result_stringifier` (returns string)

+ Add `result_viewer` as Callable[[Any], None] and `view_result()` will call it

+ [PRIO] [!!!] README.md
  https://www.markdownguide.org/basic-syntax/
  https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
  • Loading branch information
wolfhoundgelert committed Jun 1, 2023
1 parent f40ad6a commit e9ea41c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 37 deletions.
35 changes: 0 additions & 35 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -1,40 +1,5 @@
### CURRENT:

+ set result viewer - exp, group, proj level

+ Add notes saving: pickle, text, json

+ Proj methods make as Group methods (which is copying Box structure), and add them to API

+ Do TODO-s in the code
+ check exp is not active when changing its num or moving to another group
+ check exp is not active in other places
+ `get_active_experiments` for ExpProj and ExpGroup and their API - better use `filter_exps`

+ [!!!] Review destroy of active exp from active notebook (where pipeline was started) perspective and from passive notebook (just loaded the proj with active exp). Check that destroy from passive doesn't delete anything and brake active.

+ Rename `destroy_smth` in API methods because it seems like `destroy` method for GC

+ `filter_exps` from `XManAPI`, `XManProjAPI`, `XManGroupAPI` and their target classes should be implemented as a global filter system in `filter.py`.

+ change exp or group num

+ Move exp into another group

+ [!!!] Check all needed API methods exist in XManAPI
+ Implement checking system via pytest tests
+ Check and align

+ [!!!] Unlink result from the main data, move to `.result` - if someone put checkpoint into the result, it will be a cause of low performance. The same for manual result.

+ `result_viewer` rename to `result_stringifier` (returns string)

+ Add `result_viewer` as Callable[[Any], None] and `view_result()` will call it

- [PRIO] [!!!] README.md
https://www.markdownguide.org/basic-syntax/
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax



### BUGS:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name='xman',
version='0.0.11',
version='0.1.0',
packages=['xman'],
package_dir={'': 'src'},
url='/~https://github.com/wolfhoundgelert/xman',
Expand Down
2 changes: 1 addition & 1 deletion src/xman/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = '0.0.11' # TODO support auto setting from setup.py
__version__ = '0.1.0' # TODO support auto setting from setup.py


from .api import XManAPI
Expand Down

0 comments on commit e9ea41c

Please sign in to comment.