Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update of rescan state upon completion #1530

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Jan 10, 2025

This is to fix #1528.

It updates the processing field of the rescan settings each time the cache is updated.

Otherwise, all elements are expected to be `Home`.
Otherwise, the button gets stuck on "Starting rescan...".
@jp1ac4 jp1ac4 self-assigned this Jan 10, 2025
@jp1ac4 jp1ac4 added this to the v9 Liana - UI fixes and other milestone Jan 10, 2025
We already have access to the cache in the `update` arguments.
@jp1ac4 jp1ac4 force-pushed the gui-fix-rescan-status branch from 69f914b to 130d004 Compare January 10, 2025 17:44
Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 130d004
Tested rescan, code seems good

@edouardparis edouardparis merged commit f46efa2 into wizardsardine:master Jan 13, 2025
23 of 24 checks passed
edouardparis added a commit that referenced this pull request Jan 13, 2025
cfb585e backport 1530: Fix update of rescan state upon completion (edouardparis)

Pull request description:

  backport of #1530

ACKs for top commit:
  edouardparis:
    Self-ACK cfb585e

Tree-SHA512: 4d4bd9185496e6654f3108ccaec7ea47df8ac0bd013366d605d4436c9818731921edf4aab88fc3566d2edebf988b41ec6999512557b664cfea9db6ab579698a0
@jp1ac4 jp1ac4 deleted the gui-fix-rescan-status branch January 14, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rescan with "Liana managed" node does not update the state, despite finishing the rescan
2 participants