Rename contracts to simply use the name Staker #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyghayrat
reviewed
Jan 13, 2025
Generalize "governance staker" to "Staker" in the README
apbendi
force-pushed
the
rename-to-staker
branch
from
647292e to
b8b7e9d
Compare
|
Coverage after merging rename-to-staker into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
garyghayrat
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename contracts from "GovernanceStaker" to simply "Staker". Note that the change is intended to impact only the contract names and associated natspec documentation. Variable names—especially in test cases—are not intended to be updated. The reason for the change is to emphasize the fact that this is a generalizable staking system that also supports governance as a first class citizen, however it is not strictly limited to governance staking.