Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for maintenance setting containing value but null ip list #1320

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

jaxwilko
Copy link
Member

@jaxwilko jaxwilko commented Feb 27, 2025

This PR fixes an issue where the user enables maintenance mode but doesn't add any IPs to whitelist by ensuring an iteratable is passed to Arr::pluck().

image

@LukeTowers LukeTowers added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Feb 28, 2025
@LukeTowers LukeTowers added this to the 1.2.8 milestone Feb 28, 2025
@LukeTowers LukeTowers merged commit f5d93e8 into develop Feb 28, 2025
14 checks passed
@LukeTowers LukeTowers deleted the fix/maintenance-ip-empty branch February 28, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants