-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes, missing commands and endpoints #95
Draft
Lenart12
wants to merge
41
commits into
wimaha:main
Choose a base branch
from
Lenart12:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require POST parameter and have a wait flag
…ne options and usage details
Thank you for all if this! I will Review when I‘m back Home. |
…ing routes and handlers accordingly
sftman18
reviewed
Feb 8, 2025
Hi, I'm back and will now start to look through all the changes. |
Hello, still working on a couple of upstream fixes in vehicle-command before ready to merge, but nothing should change in this PR ideally. |
@wimaha : Will the merge effect the integration into evcc or required updates on the template in evcc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
TeslaBleHttpProxy
project. It changes quite a bit of things and is fairly large. The most important changes are summarized below:Code Refactoring:
/api/proxy/1/vehicles/VIN/connection_status
. Closes Add BT information #78internal/api/handlers/tesla.go
to make sure all endpoints use operated connection command processing logic, includingbody-controller-state
.body-controller-state
endpoint to/api/proxy/1/vehicles/VIN/body_controller_state
to be consistent with naming scheme. Movedwake_up
to/api/1/vehicles/VIN/wake_up
to be consistent with Tesla API.vehicle_data
and added missing categories. Added manual json formatting forbody-controller-state
, fixes vehicleLockState missing for unlocked vehicle? #87 .internal/api/handlers/tesla.go
.wake_up
command to wait for car to wake up withwait=true
parameterX-Ingress-Path
for running this app behind a reverse proxy.Configuration Enhancements:
scanTimeout
configuration parameter inconfig/config.go
to control the scan duration for BLE beacons.cacheMaxAge
environment variable default value in theREADME.md
to 5 seconds.keys
parameter to allow reading keys from a different directory.dashboardBaseUrl
andapiBaseUrl
for configuring paths when running behind a reverse proxy.Dependency Updates:
github.com/teslamotors/vehicle-command
dependency ingo.mod
to a newer version.go.mod
, sincego_bleConnectFix
is now not neccesary anymore :^)Documentation Updates:
README.md
to include a reference toTeslaBle2Mqtt
and added a comprehensive list of supported endpoints for vehicle data.wait
parameter.README.md
.