Replace the JS test runner #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses npm to install the testsuite dependencies instead of vendoring them in the project to make the setup easier to maintain. This also removes the file loading the ES5-shim as all maintained browsers support ES5 natively anyway.
PhantomJS is not maintained anymore and the setup was broken. The new setup uses `@web/test-runner` to run the QUnit tests in an actual browser.
|
Thanks @stof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the outdated setup using the unmaintained phantomjs, this now uses
@web/test-runnerand runs tests in an actual browser.I also updated QUnit to its latest version instead of the totally outdated version used before.
To run tests locally, I kept the
index.htmlthat supports standalone run of QUnit, even thoughnpm test -- --manualis also possible thanks to the manual mode of@web/test-runner