-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] New Option for Help, Initial Module, and Tests for the Source Code Documentation #6
Conversation
At the moment, the project consists of a single monolithic source file which might require additional effort to maintain the source code. Hence, I decided to outsource the features to dedicated modules. Together with the intended source code documentation, as discussed in #5, this procedure keeps the code better readable. I decided to begin with the |
Okay, before I start dissecting your pull request: Please run Secondly run |
Okay, I applied your suggestions. Please note that the linter still complains about 6 regions which I do not edited with none of my commits. I order to do not modify the behaviour of the application unintendedly, I would prefer to leave them as they are, at the moment. |
Mostly, the complaints concern the closures of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some feedback here 😄
Yeah I saw that. I will fix these after the pull request merged I think 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 😄
I just found out the solutions to the linter warnings. I am going to submit them to this Pull Request. |
The sole open linter warning concerns the unused |
Thanks, I merged it. And will now look at the unused merge field. 😄 |
Hello, @wert007,
This Pull Request introduces the following new features:
cargo doc
.This Pull Request is also intended to discuss the source code style in order to agree on some initial contribution guidelines.