Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Option to generate report file #118

Merged
merged 5 commits into from
Oct 17, 2016
Merged

Option to generate report file #118

merged 5 commits into from
Oct 17, 2016

Conversation

vidhill
Copy link
Contributor

@vidhill vidhill commented Oct 12, 2016

This is about my second pull request ever so be gentle..

I have added the option to be able to write the ESLint output to a file, optionally using a different formatter,
I am trying to use webpack on Jenkins CI and I needed to output a checkstyle xml file for reporting

#89

@MoOx
Copy link
Contributor

MoOx commented Oct 13, 2016

Hi. Thanks for you contribution. Would you mind adding a automated test for this?

@vidhill
Copy link
Contributor Author

vidhill commented Oct 13, 2016

I can,
I've never written tests for build output before but I'll use the existing ones to give me direction,
Will do this this evening.

thanks

@vidhill
Copy link
Contributor Author

vidhill commented Oct 14, 2016

Ok, I have created a test case..

Haven't written many tests for builds, hope this is okay.

@MoOx MoOx merged commit 548504a into webpack-contrib:master Oct 17, 2016
@MoOx
Copy link
Contributor

MoOx commented Oct 17, 2016

Nice work!

@MoOx
Copy link
Contributor

MoOx commented Oct 17, 2016

Released as 1.6.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants