Phpstan Level 3

docs/type-system/scalar-types.md

@@ -100,7 +100,7 @@ class EmailType extends ScalarType
      * @return string
      * @throws Error
      */
-    public function parseLiteral($valueNode, array $variables = null)
+    public function parseLiteral(Node $valueNode, ?array $variables = null)
     {
         // Note: throwing GraphQL\Error\Error vs \UnexpectedValueException to benefit from GraphQL
         // error location in query:

examples/01-blog/Blog/Type/Scalar/UrlType.php

@@ -48,7 +48,7 @@ public function parseValue($value)
      * @return null|string
      * @throws Error
      */
-    public function parseLiteral($valueNode, array $variables = null)
+    public function parseLiteral(Node $valueNode, ?array $variables = null)
     {
         // Note: throwing GraphQL\Error\Error vs \UnexpectedValueException to benefit from GraphQL
         // error location in query:

phpstan.neon.dist

@@ -1,5 +1,9 @@
 parameters:
-    level: 2
+    level: 3
+
+    reportUnmatchedIgnoredErrors: false
+
+    inferPrivatePropertyTypeFromConstructor: true
 
     paths:
         - %currentWorkingDirectory%/src
@@ -23,6 +27,20 @@ parameters:
         - "~Access to an undefined property GraphQL\\\\Language\\\\AST\\\\Node::\\$value~"
 
 includes:
-	- vendor/phpstan/phpstan-phpunit/extension.neon
-	- vendor/phpstan/phpstan-phpunit/rules.neon
-	- vendor/phpstan/phpstan-strict-rules/rules.neon
+    - vendor/phpstan/phpstan-phpunit/extension.neon
+    - vendor/phpstan/phpstan-phpunit/rules.neon
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
+
+services:
+    -
+        class: GraphQL\Tests\PhpStan\Type\Definition\Type\IsInputTypeStaticMethodTypeSpecifyingExtension
+        tags:
+            - phpstan.typeSpecifier.staticMethodTypeSpecifyingExtension
+    -
+        class: GraphQL\Tests\PhpStan\Type\Definition\Type\IsOutputTypeStaticMethodTypeSpecifyingExtension
+        tags:
+            - phpstan.typeSpecifier.staticMethodTypeSpecifyingExtension
+    -
+        class: GraphQL\Tests\PhpStan\Type\Definition\Type\IsCompositeTypeStaticMethodTypeSpecifyingExtension
+        tags:
+            - phpstan.typeSpecifier.staticMethodTypeSpecifyingExtension

src/Error/Error.php

@@ -330,6 +330,8 @@ public function getExtensions()
      * @deprecated Use FormattedError::createFromException() instead
      *
      * @return mixed[]
+     *
+     * @codeCoverageIgnore
      */
     public function toSerializableArray()
     {

src/Error/FormattedError.php

@@ -427,6 +427,8 @@ static function ($loc) {
      * @deprecated as of v0.10.0, use general purpose method createFromException() instead
      *
      * @return mixed[]
+     *
+     * @codeCoverageIgnore
      */
     public static function createFromPHPError(ErrorException $e)
     {

src/Executor/ReferenceExecutor.php

@@ -238,7 +238,7 @@ private function buildResponse($data)
      *
      * @param  mixed $rootValue
      *
-     * @return Promise|stdClass|mixed[]
+     * @return Promise|stdClass|mixed[]|null
      */
     private function executeOperation(OperationDefinitionNode $operation, $rootValue)
     {
@@ -993,7 +993,7 @@ private function completeAbstractValue(AbstractType $returnType, $fieldNodes, Re
      * @param mixed|null              $contextValue
      * @param InterfaceType|UnionType $abstractType
      *
-     * @return ObjectType|Promise|null
+     * @return Promise|Type|string|null
      */
     private function defaultTypeResolver($value, $contextValue, ResolveInfo $info, AbstractType $abstractType)
     {
@@ -1023,7 +1023,7 @@ private function defaultTypeResolver($value, $contextValue, ResolveInfo $info, A
         $possibleTypes           = $info->schema->getPossibleTypes($abstractType);
         $promisedIsTypeOfResults = [];
         foreach ($possibleTypes as $index => $type) {
-            $isTypeOfResult = $type->isTypeOf($value, $contextValue, $info);
+            $isTypeOfResult = $type instanceof ObjectType ? $type->isTypeOf($value, $contextValue, $info) : null;
             if ($isTypeOfResult === null) {
                 continue;
             }

src/Executor/Values.php

@@ -303,6 +303,8 @@ public static function getArgumentValuesForMap($fieldDefinition, $argumentValueM
      * @param mixed[]|null                                                                                                                        $variables
      *
      * @return mixed[]|stdClass|null
+     *
+     * @codeCoverageIgnore
      */
     public static function valueFromAST(ValueNode $valueNode, InputType $type, ?array $variables = null)
     {
@@ -316,6 +318,7 @@ public static function valueFromAST(ValueNode $valueNode, InputType $type, ?arra
      *
      * @return string[]
      *
+     * @codeCoverageIgnore
      * @paarm ScalarType|EnumType|InputObjectType|ListOfType|NonNull $type
      */
     public static function isValidPHPValue($value, InputType $type)

src/Experimental/Executor/Collector.php

@@ -46,7 +46,7 @@ class Collector
     /** @var FieldNode[][] */
     private $fields;
 
-    /** @var string[] */
+    /** @var array<string, bool> */
     private $visitedFragments;
 
     public function __construct(Schema $schema, Runtime $runtime)

src/Experimental/Executor/CoroutineContext.php

@@ -27,7 +27,7 @@ class CoroutineContext
     /** @var string[] */
     public $path;
 
-    /** @var ResolveInfo|null */
+    /** @var ResolveInfo */
     public $resolveInfo;
 
     /** @var string[]|null */

src/Experimental/Executor/CoroutineExecutor.php

@@ -33,12 +33,15 @@
 use GraphQL\Type\Introspection;
 use GraphQL\Type\Schema;
 use GraphQL\Utils\AST;
+use GraphQL\Utils\TypeInfo;
 use GraphQL\Utils\Utils;
 use SplQueue;
 use stdClass;
 use Throwable;
 use function is_array;
 use function is_string;
+use function json_decode;
+use function json_encode;
 use function sprintf;
 
 class CoroutineExecutor implements Runtime, ExecutorImplementation
@@ -73,10 +76,10 @@ class CoroutineExecutor implements Runtime, ExecutorImplementation
     /** @var string|null */
     private $operationName;
 
-    /** @var Collector */
+    /** @var Collector|null */
     private $collector;
 
-    /** @var Error[] */
+    /** @var array<Error> */
     private $errors;
 
     /** @var SplQueue */
@@ -85,10 +88,10 @@ class CoroutineExecutor implements Runtime, ExecutorImplementation
     /** @var SplQueue */
     private $schedule;
 
-    /** @var stdClass */
+    /** @var stdClass|null */
     private $rootResult;
 
-    /** @var int */
+    /** @var int|null */
     private $pending;
 
     /** @var callable */
@@ -108,6 +111,9 @@ public function __construct(
             self::$undefined = Utils::undefined();
         }
 
+        $this->errors            = [];
+        $this->queue             = new SplQueue();
+        $this->schedule          = new SplQueue();
         $this->schema            = $schema;
         $this->fieldResolver     = $fieldResolver;
         $this->promiseAdapter    = $promiseAdapter;
@@ -143,10 +149,11 @@ public static function create(
     private static function resultToArray($value, $emptyObjectAsStdClass = true)
     {
         if ($value instanceof stdClass) {
-            $array = [];
-            foreach ($value as $propertyName => $propertyValue) {
+            $array = (array) $value;
+            foreach ($array as $propertyName => $propertyValue) {
                 $array[$propertyName] = self::resultToArray($propertyValue);
             }
+
             if ($emptyObjectAsStdClass && empty($array)) {
                 return new stdClass();
             }
@@ -237,9 +244,9 @@ public function doExecute() : Promise
     private function finishExecute($value, array $errors) : ExecutionResult
     {
         $this->rootResult     = null;
-        $this->errors         = null;
-        $this->queue          = null;
-        $this->schedule       = null;
+        $this->errors         = [];
+        $this->queue          = new SplQueue();
+        $this->schedule       = new SplQueue();
         $this->pending        = null;
         $this->collector      = null;
         $this->variableValues = null;
@@ -825,11 +832,16 @@ private function completeValue(CoroutineContext $ctx, Type $type, $value, array
                 } else {
                     $childContexts = [];
 
+                    $fields = [];
+                    if ($this->collector !== null) {
+                        $fields = $this->collector->collectFields(
+                            $objectType,
+                            $ctx->shared->mergedSelectionSet ?? $this->mergeSelectionSets($ctx)
+                        );
+                    }
+
                     /** @var CoroutineContextShared $childShared */
-                    foreach ($this->collector->collectFields(
-                        $objectType,
-                        $ctx->shared->mergedSelectionSet ?? $this->mergeSelectionSets($ctx)
-                    ) as $childShared) {
+                    foreach ($fields as $childShared) {
                         $childPath   = $path;
                         $childPath[] = $childShared->resultName; // !!! uses array COW semantics
                         $childCtx    = new CoroutineContext(
@@ -937,8 +949,8 @@ private function resolveTypeSlow(CoroutineContext $ctx, $value, AbstractType $ab
 
         $selectedType = null;
         foreach ($possibleTypes as $type) {
-            $typeCheck = yield $type->isTypeOf($value, $this->contextValue, $ctx->resolveInfo);
-            if ($selectedType !== null || $typeCheck !== true) {
+            $typeCheck = yield $type instanceof ObjectType ? $type->isTypeOf($value, $this->contextValue, $ctx->resolveInfo) : null;
+            if ($selectedType !== null || ! $typeCheck) {
                 continue;
             }
 

src/GraphQL.php

@@ -16,6 +16,7 @@
 use GraphQL\Language\Parser;
 use GraphQL\Language\Source;
 use GraphQL\Type\Definition\Directive;
+use GraphQL\Type\Definition\ScalarType;
 use GraphQL\Type\Definition\Type;
 use GraphQL\Type\Schema as SchemaType;
 use GraphQL\Validator\DocumentValidator;
@@ -182,6 +183,8 @@ public static function promiseToExecute(
      * @param mixed[]|null        $variableValues
      *
      * @return Promise|mixed[]
+     *
+     * @codeCoverageIgnore
      */
     public static function execute(
         SchemaType $schema,
@@ -227,6 +230,8 @@ public static function execute(
      * @param mixed[]|null        $variableValues
      *
      * @return ExecutionResult|Promise
+     *
+     * @codeCoverageIgnore
      */
     public static function executeAndReturnResult(
         SchemaType $schema,
@@ -287,7 +292,7 @@ public static function getStandardTypes() : array
      * Replaces standard types with types from this list (matching by name)
      * Standard types not listed here remain untouched.
      *
-     * @param Type[] $types
+     * @param array<string, ScalarType> $types
      *
      * @api
      */
@@ -345,6 +350,8 @@ public static function useReferenceExecutor()
      * @deprecated Renamed to getStandardDirectives
      *
      * @return Directive[]
+     *
+     * @codeCoverageIgnore
      */
     public static function getInternalDirectives() : array
     {

src/Language/AST/DocumentNode.php

@@ -9,6 +9,6 @@ class DocumentNode extends Node
     /** @var string */
     public $kind = NodeKind::DOCUMENT;
 
-    /** @var NodeList|DefinitionNode[] */
+    /** @var NodeList|array<DefinitionNode> */
     public $definitions;
 }

src/Language/DirectiveLocation.php

@@ -54,12 +54,7 @@ class DirectiveLocation
         self::INPUT_FIELD_DEFINITION => self::INPUT_FIELD_DEFINITION,
     ];
 
-    /**
-     * @param string $name
-     *
-     * @return bool
-     */
-    public static function has($name)
+    public static function has(string $name) : bool
     {
         return isset(self::$locations[$name]);
     }

src/Language/Parser.php

@@ -1295,7 +1295,7 @@ private function parseImplementsInterfaces()
     }
 
     /**
-     * @return FieldDefinitionNode[]|NodeList
+     * @return array<FieldDefinitionNode>|NodeList
      *
      * @throws SyntaxError
      */

src/Language/Token.php

@@ -81,18 +81,13 @@ class Token
      */
     public $prev;
 
-    /** @var Token */
+    /** @var Token|null */
     public $next;
 
     /**
-     * @param string     $kind
-     * @param int        $start
-     * @param int        $end
-     * @param int        $line
-     * @param int        $column
-     * @param mixed|null $value
+     * @param mixed $value
      */
-    public function __construct($kind, $start, $end, $line, $column, ?Token $previous = null, $value = null)
+    public function __construct(string $kind, int $start, int $end, int $line, int $column, ?Token $previous = null, $value = null)
     {
         $this->kind   = $kind;
         $this->start  = $start;

src/Language/Visitor.php

@@ -393,7 +393,7 @@ public static function removeNode()
     /**
      * @param callable[][] $visitors
      *
-     * @return callable[][]
+     * @return array<string, callable>
      */
     public static function visitInParallel($visitors)
     {

src/Server/Helper.php

@@ -146,7 +146,7 @@ public function parseRequestParams($method, array $bodyParams, array $queryParam
      * Checks validity of OperationParams extracted from HTTP request and returns an array of errors
      * if params are invalid (or empty array when params are valid)
      *
-     * @return Error[]
+     * @return array<int, RequestError>
      *
      * @api
      */
@@ -285,6 +285,11 @@ static function (RequestError $err) {
             }
 
             $operationType = AST::getOperation($doc, $op->operation);
+
+            if ($operationType === false) {
+                throw new RequestError('Failed to determine operation type');
+            }
+
             if ($operationType !== 'query' && $op->isReadOnly()) {
                 throw new RequestError('GET supports only query operation');
             }
@@ -385,11 +390,9 @@ private function resolveValidationRules(
     }
 
     /**
-     * @param string $operationType
-     *
      * @return mixed
      */
-    private function resolveRootValue(ServerConfig $config, OperationParams $params, DocumentNode $doc, $operationType)
+    private function resolveRootValue(ServerConfig $config, OperationParams $params, DocumentNode $doc, string $operationType)
     {
         $rootValue = $config->getRootValue();
 

src/Type/Definition/BooleanType.php

@@ -49,14 +49,11 @@ public function parseValue($value)
     }
 
     /**
-     * @param Node         $valueNode
      * @param mixed[]|null $variables
      *
-     * @return bool|null
-     *
      * @throws Exception
      */
-    public function parseLiteral($valueNode, ?array $variables = null)
+    public function parseLiteral(Node $valueNode, ?array $variables = null)
     {
         if (! $valueNode instanceof BooleanValueNode) {
             // Intentionally without message, as all information already in wrapped Exception