-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(tooling): webpack-prod-build-for-npm (#383)
- Loading branch information
1 parent
47c4a2e
commit 648b6b3
Showing
4 changed files
with
54 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
<!-- | ||
Hey there,\ | ||
Thank you for taking the time to improve our code! 🙂\ | ||
Please let us know why this change is necessary and what testing you have performed. \ | ||
This ensures our reviewers understand the impact of your change. \ | ||
**IMPORTANT** | ||
FAILING TO FILL OUT THIS TEMPLATE WILL RESULT IN REJECTION OF YOUR PULL REQUEST | ||
This is for compliance purposes with FedRAMP program. | ||
--> | ||
|
||
# COMPLETES #< INSERT LINK TO ISSUE > | ||
|
||
## This pull request addresses | ||
|
||
< DESCRIBE THE CONTEXT OF THE ISSUE > | ||
|
||
## by making the following changes | ||
|
||
< DESCRIBE YOUR CHANGES > | ||
|
||
<!-- You may include screenshots --> | ||
|
||
### Change Type | ||
|
||
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> | ||
|
||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
- [ ] Documentation update | ||
- [ ] Tooling change | ||
- [ ] Internal code refactor | ||
|
||
## The following scenarios were tested | ||
|
||
- [ ] The testing is done with the amplify link | ||
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED > | ||
|
||
### Checklist before merging | ||
|
||
- [ ] I have not skipped any automated checks | ||
- [ ] All existing and new tests passed | ||
- [ ] I have updated the testing document | ||
- [ ] I have tested the functionality with amplify link | ||
|
||
--- | ||
|
||
Make sure to have followed the [contributing guidelines](/~https://github.com/webex/webex-js-sdk/blob/master/CONTRIBUTING.md#submitting-a-pull-request) before submitting. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters