Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user defined OTEL resource attributes #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clly
Copy link

@clly clly commented Jun 24, 2021

This will add support for pulling in opentelemetry's default attributes
It adds sdk information, service.name and discrete key/value entries as
specified on the environment and local host information such as the
hostname and instance.

This will add support for pulling in opentelemetry's default attributes
It adds sdk information, service.name and discrete key/value entries as
specified on the environment and local host information such as the
hostname and instance.
@bboreham
Copy link
Collaborator

Thanks for the PR.

Can you describe how those attributes are useful for Kspan? It generates spans that claim to come from many different components such as kubectl, scheduler, controller-manager, so I wonder if it would be confusing that they all have the same host information.

@clly
Copy link
Author

clly commented Jul 11, 2021

Sorry about that. One of the default attributes is also anything that exists in the OTEL_RESOURCE_ATTRIBUTES environment variable.

This change pulls that in as well as all the SDK and local host/runtime environment information

@clly
Copy link
Author

clly commented Jul 12, 2021

It is possible to only pull in the environment variable attributes instead of everything. If that's preferred let me know and I can change it

@bboreham
Copy link
Collaborator

Yes, might be safer to start just with the env-vars.

@clly
Copy link
Author

clly commented Jul 23, 2021

I've updated the PR to only pull in resources from the environment

@clly clly changed the title Add support for OTEL default resource attributes Add support for user defined OTEL resource attributes Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants