Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page for offenses and slashes #5878

Merged
merged 26 commits into from
Jun 10, 2024
Merged

New page for offenses and slashes #5878

merged 26 commits into from
Jun 10, 2024

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented May 7, 2024 •
edited
Loading

  • Created a page to explain offenses and punishments
  • Diverted content from existing pages there
  • Rm maintain page about how to prevent slahes, implemented redirect
  • Content reorg

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label May 7, 2024
@filippoweb3 filippoweb3 self-assigned this May 7, 2024
@filippoweb3 filippoweb3 linked an issue May 7, 2024 that may be closed by this pull request
Add Beefy equivocation offences to the Advanced Staking Concepts #5852
Closed
filippoweb3 added 5 commits May 7, 2024 14:58
@filippoweb3
moved content
cf5705c 
- added links to new page
- added new page to sidebar
@filippoweb3
edits
c67a0ea
@filippoweb3
banners and reorg content
071a3ec
@filippoweb3
reorg content
ea9f7b8 
- moved content to new page
- redirect
- rm duplicated content
- keywords
@filippoweb3
edits
98bc194
@filippoweb3
Copy link
Contributor Author

@Overkillus I created this new page. I left a few sections with TODO because I did not get the meaning of the terminology from your documentation. Can you please provide some feedback and ensure the content overall is up-to-date?

@filippoweb3 filippoweb3 requested a review from DrW3RK May 8, 2024 10:35
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels May 8, 2024
Overkillus
Overkillus reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@Overkillus Overkillus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some corrections and suggested changes. Overall having a dedicated page for it was much needed so thanks!

We should consider adding a disclaimer on the slashing page that those are specifically protocol level slashes. Various parachains or applications living on top of Polkadot might add various economic schemes and include slashes but they would be unrelated to those slashes described here as they only refer to the staked tokens.

If anything is unclear please ask. If you or whoever else edits the wiki understands how it all works then this best ensures that whatever will be here in the future will remain accurate.

docs/build/build-oracle.md Outdated Show resolved Hide resolved
docs/general/glossary.md Outdated Show resolved Hide resolved
docs/general/glossary.md Outdated Show resolved Hide resolved
docs/learn/learn-comparison-rollups.md Outdated Show resolved Hide resolved
docs/learn/learn-guides-identity.md Outdated Show resolved Hide resolved
docs/learn/learn-offenses.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains-protocol.md Outdated Show resolved Hide resolved
docs/learn/learn-staking.md Outdated Show resolved Hide resolved
docs/learn/learn-staking.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains-protocol.md Outdated Show resolved Hide resolved
DrW3RK and others added 15 commits May 14, 2024 08:51
@DrW3RK @Overkillus
Update docs/learn/learn-comparison-rollups.md
c797028 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
c356031 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
d46a674 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
c730225 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
3ce41da 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-staking.md
42c8c1f 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-staking.md
35aad05 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-parachains-protocol.md
9b6854a 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
edf2c2a 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
e0d6877 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
ed13302 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
e9db708 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
5fad889 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
360cd9c 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK @Overkillus
Update docs/learn/learn-offenses.md
8a4a782 
Co-authored-by: Maciej <kz_sky@outlook.com>
@DrW3RK DrW3RK mentioned this pull request May 14, 2024
Merged
@filippoweb3
Copy link
Contributor Author

@Overkillus thanks for the feedback in this PR, I implemented your feedback. Lmk if this is good to go :) I am generally happy now we have a page with all relevant, up-to-date info!

@Overkillus Overkillus linked an issue Jun 10, 2024 that may be closed by this pull request
W3F wiki for slashing and disabling paritytech/polkadot-sdk#4747
Closed
Overkillus
Overkillus approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Overkillus Overkillus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo and looks good!

There is a lot of information here but at least it is up-to-date and correct now 😄. Maybe in the future we can work on making it all more digestible.

docs/learn/learn-offenses.md Outdated Show resolved Hide resolved
@filippoweb3 filippoweb3 merged commit e73105e into master Jun 10, 2024
2 checks passed
@filippoweb3 filippoweb3 deleted the offences branch June 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Overkillus Overkillus Overkillus approved these changes

@DrW3RK DrW3RK Awaiting requested review from DrW3RK

Assignees

@filippoweb3 filippoweb3

Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

W3F wiki for slashing and disabling Add Beefy equivocation offences to the Advanced Staking Concepts
3 participants
@filippoweb3 @Overkillus @DrW3RK