This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Issue accurate Content-Length whenever possible #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several scenarios where we are serving content without setting the Content-Length header. Today have a safeguard in place to force the connection close in the absence of a Content-Length, since HTTP 1.1 uses keepalive connections by default. However in many of these cases we know or can easily determine the content length ahead of time.
Example: Normal request for a file
Example: Range requests
Example:
sub
pipeExample:
slice
pipeExample: HEAD request
Example:
header
pipe overridingContent-Length
Note in particular as shown in the last example that the default Content-Length does not overwrite any explicitly-specified Content-Length header (set by pipes, .header files, Python etc.) This keeps in the spirit of wptserve being a well-behaved HTTP server by default, but which can be customized even to send invalid HTTP responses in order to test how browsers handle them.
Ref: #17
This change is