Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow same named static and nonstatic operations #673

Merged
merged 1 commit into from
May 20, 2022
Merged

Allow same named static and nonstatic operations #673

merged 1 commit into from
May 20, 2022

Conversation

saschanaz
Copy link
Member

This patch closes #672 and includes:

  • A relevant test
  • A relevant documentation update (N/A)

@saschanaz saschanaz requested a review from marcoscaceres May 19, 2022 02:33
marcoscaceres
marcoscaceres approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@saschanaz saschanaz merged commit 4a4be1f into main May 20, 2022
@saschanaz saschanaz deleted the static-op-fix branch May 20, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"no-cross-overload" should not fire on static and regular operations with same identifier
2 participants
@saschanaz @marcoscaceres