-
-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore[test]: add macos to test matrix #4025
Merged
charles-cooper
merged 16 commits into
vyperlang:master
from
DanielSchiavini:test/windows-pipeline
May 15, 2024
Merged
chore[test]: add macos to test matrix #4025
charles-cooper
merged 16 commits into
vyperlang:master
from
DanielSchiavini:test/windows-pipeline
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 40c6c4a.
let's put the OS in the front of the job name. we can also drop it in the default case, we only need to distinguish for windows + macos |
DanielSchiavini
force-pushed
the
test/windows-pipeline
branch
from
May 15, 2024 15:01
10eb41f
to
15bc75c
Compare
charles-cooper
changed the title
chore[test]: multi-platform test matrix
chore[test]: add macos to test matrix
May 15, 2024
charles-cooper
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
includes
section should contain alternative runs - these will not have all default values definedHow to verify it
Commit message
Description for the changelog
N/A
Cute Animal Picture