Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing _ne field to pipeline state create infos #2240

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add missing _ne field to pipeline state create infos #2240

merged 1 commit into from
Jun 27, 2023

Conversation

marc0246
Copy link
Contributor

Changelog:
Remove:

### Breaking changes
Changes to pipeline construction:
- Added a `domain_origin` field to `TessellationState`.

Add:

### Breaking changes
Changes to pipeline construction:
- Added a `_ne` field to all pipeline state create info structs, as they should have had all along.

### Additions
- Added a `domain_origin` field to `TessellationState`.

See #2224 (comment) for context.

@Rua
Copy link
Contributor

Rua commented Jun 27, 2023

Thanks! I meant to do that in #2234 but forgot.

@Rua Rua merged commit a9c41ee into vulkano-rs:master Jun 27, 2023
Rua added a commit that referenced this pull request Jun 27, 2023
@Rua
#2240 changelog
4eceb49
@marc0246 marc0246 deleted the pipeline-state-exhaustiveness branch June 27, 2023 18:11
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
Add missing _ne field to pipeline state create infos (vulkano-rs#2240)
db93294
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
vulkano-rs#2240 changelog
afa9d62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc0246 @Rua