Skip to content

Commit

Permalink
Ensure rundeck directories are owned by $user and $group
Browse files Browse the repository at this point in the history
  • Loading branch information
danifr committed Mar 7, 2016
1 parent 4748a93 commit 23b9244
Showing 1 changed file with 29 additions and 4 deletions.
33 changes: 29 additions & 4 deletions manifests/install.pp
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,35 @@
}

file { $rdeck_home:
ensure => directory,
owner => $user,
group => $group,
mode => '0755',
ensure => directory,
recurse => true,

This comment has been minimized.

Copy link
@dalisch

dalisch Mar 8, 2016

Contributor

This line is causing some problems with activities using the Rundeck ssh keys, as 'recurse => true' also affects the ~/.ssh/ directory, which in turn changes mode of the private key 'id_rsa' from '0600' (default, correct) to '0640' (unsecure for a private key). Opening a defect here.

This comment has been minimized.

Copy link
@jyaworski

jyaworski Mar 8, 2016

Member

Wow, I didn't see the recurse. Yes, this shouldn't be recursive... or maybe we manage .ssh separately?

This comment has been minimized.

Copy link
@dalisch

dalisch Mar 8, 2016

Contributor

Opened defect: #196

My suggestion would be to leave .ssh alone for now, but I'd like some more discussion on this. I'll probably take a look at fixing this myself if I have time later this week and we can discuss it a bit more in the PR...

owner => $user,
group => $group,
mode => '0640',
}

file { $rundeck::params::service_logs_dir:
ensure => directory,
recurse => true,
owner => $user,
group => $group,
mode => '0640',
}

file { $rundeck::params::framework_config['framework.etc.dir']:
ensure => directory,
recurse => true,
owner => $user,
group => $group,
mode => '0640',
}

file { '/var/rundeck/':
ensure => directory,
recurse => true,
owner => $user,
group => $group,
mode => '0640',
}

ensure_resource(file, $projects_dir, {'ensure' => 'directory', 'owner' => $user, 'group' => $group})
Expand Down

0 comments on commit 23b9244

Please sign in to comment.