fix(label): allow signposts inside labels #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
dtsanevmw
force-pushed
the
dtsanevmw/cde-9
branch
4 times, most recently
from
bc86de3 to
2c719c3
Compare
williamernest
suggested changes
Sep 7, 2023
dtsanevmw
force-pushed
the
dtsanevmw/cde-9
branch
2 times, most recently
from
010bb33 to
4d5c056
Compare
|
Will wait the popover refactor #1435 to be merged |
kevinbuhmann
requested changes
Nov 18, 2024
Co-authored-by: Kevin Buhmann <kbuhmann@vmware.com>
dtsanevmw
force-pushed
the
dtsanevmw/cde-9
branch
2 times, most recently
from
c6928d1 to
1528a5a
Compare
dtsanevmw
force-pushed
the
dtsanevmw/cde-9
branch
2 times, most recently
from
f755fab to
1928be8
Compare
kevinbuhmann
reviewed
Jan 7, 2025
kevinbuhmann
reviewed
Jan 7, 2025
dtsanevmw
force-pushed
the
dtsanevmw/cde-9
branch
from
1928be8 to
bc9b2ab
Compare
kevinbuhmann
approved these changes
Jan 7, 2025
|
🎉 This PR is included in version 17.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently if you put signposts inside labels they are not working due to that
<label>be default is spreading a click event to its children and that's causing the signpost to automatically close and not appear.Example:
If you have a label attached to an input or input inside a label and click the label - the input will get focused.
Issue Number: CDE-9 and #271
What is the new behavior?
Signposts are now working inside
<label>.Does this PR introduce a breaking change?
Other information