Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): align checkbox with text in datagrid (port of #1006) #1011

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Position of checkbox in data grid is not aligned with text.
image

Issue Number: CDE-1350

What is the new behavior?

Position of checkbox is centered with text's first line.
image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov
Copy link
Contributor Author

Port of #1006 to next.

@github-actions
Copy link
Contributor

This PR introduces visual changes: 153f825
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout checkbox-text-datagrid_cde-1350_next
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 153f8257612b34cfafdbb046ccf0ccc430a31a54
git cherry-pick 153f8257612b34cfafdbb046ccf0ccc430a31a54
git push

@valentin-mladenov valentin-mladenov merged commit a550051 into next Oct 19, 2023
@valentin-mladenov valentin-mladenov deleted the checkbox-text-datagrid_cde-1350_next branch October 19, 2023 09:43
mivaylo pushed a commit that referenced this pull request Oct 25, 2023
…1011)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Position of checkbox in data grid is not aligned with text.

![image](/~https://github.com/vmware-clarity/ng-clarity/assets/6692908/b876edd4-fed8-4804-ba8a-613296ed74af)

Issue Number: CDE-1350

## What is the new behavior?

Position of checkbox is centered with text's first line.

![image](/~https://github.com/vmware-clarity/ng-clarity/assets/6692908/e8e632ef-d186-4eb6-948d-8ab3c617fd11)

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: GitHub <noreply@github.com>
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants