This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add property CustomSvg to icons and navigation #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftovaro
force-pushed
the
issue-1422
branch
10 times, most recently
from
3701e53 to
5066163
Compare
web/src/app/modules/shared/services/navigation/navigation.service.ts
Outdated
Show resolved
Hide resolved
ftovaro
force-pushed
the
issue-1422
branch
12 times, most recently
from
2954a80 to
44c272f
Compare
xtreme-vikram-yadav
force-pushed
the
issue-1422
branch
4 times, most recently
from
eaaa566 to
0d3a017
Compare
xtreme-vikram-yadav
force-pushed
the
issue-1422
branch
2 times, most recently
from
93be701 to
7147729
Compare
| @@ -53,6 +53,32 @@ export const iconWithTooltipView= { | |||
| } | |||
| }; | |||
|
|
|||
| export const svg = ` | |||
There was a problem hiding this comment.
The validation might be too aggressive. This is valid input currently being filtered out as seen in storybook
xtreme-vikram-yadav
force-pushed
the
issue-1422
branch
2 times, most recently
from
9d8665f to
d57fdf8
Compare
Signed-off-by: ftovaro <f.tovar12@gmail.com> Signed-off-by: Vikram Yadav <yvikram@vmware.com>
xtreme-vikram-yadav
force-pushed
the
issue-1422
branch
from
d57fdf8 to
e5ddae6
Compare
GuessWhoSamFoo
approved these changes
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows plugin authors to setup their own personal SVG for their plugins
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: