This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Allow ContentResponse to receive multiple components next to a title #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftovaro
force-pushed
the
issue-2302
branch
4 times, most recently
from
d0e8376 to
c3548ea
Compare
lenriquez
reviewed
May 3, 2021
lenriquez
reviewed
May 3, 2021
web/src/app/modules/shared/components/presentation/breadcrumb/breadcrumb.component.html
Outdated
Show resolved
Hide resolved
ftovaro
force-pushed
the
issue-2302
branch
4 times, most recently
from
5b0a62b to
c8eacb4
Compare
GuessWhoSamFoo
suggested changes
May 4, 2021
web/src/app/modules/shared/components/presentation/tabs/tabs.component.html
Outdated
Show resolved
Hide resolved
ftovaro
force-pushed
the
issue-2302
branch
3 times, most recently
from
878473a to
d3973dd
Compare
GuessWhoSamFoo
suggested changes
May 4, 2021
web/src/app/modules/shared/components/presentation/tabs/tabs.component.html
Outdated
Show resolved
Hide resolved
web/src/app/modules/sugarloaf/components/smart/content/content.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: ftovaro <f.tovar12@gmail.com>
GuessWhoSamFoo
approved these changes
May 5, 2021
|
Great job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ftovaro f.tovar12@gmail.com
What this PR does / why we need it:
Allows ContentResponse to receive multiple components, this is an extension our titles and gives the option to have complex titles with buttons, links, icons and other components.
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: