This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
increase timeout for remote cmd stream setup #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[vmware-archive#2164] Signed-off-by: vikram yadav <vyadav@pivotal.io>
xtreme-vikram-yadav
force-pushed
the
fix-term-stream
branch
from
0f94ca9 to
13fb8c5
Compare
GuessWhoSamFoo
approved these changes
Apr 2, 2021
This was referenced May 1, 2021
|
To Whom It May Concern: Consider upgrading to Octant v0.19.0 if you're using Octant v0.17.0 and v0.18.0. Why: Feature Change default shell to bash #1533's initial implementation, Add support for windows shells and bash #1749 released in v0.17.0 and v0.18.0, has a bug of: with operating systems without A bug fix increase timeout for remote cmd stream setup #2258 released in v0.19.0, fixed a similar bug No option to choose the interpreter on the terminal #2164. After the bug fix, operating systems without Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR fixes the flaky terminal connection error.
Which issue(s) this PR fixes
Special notes for your reviewer:
We already try multiple shell commands(sh, bash) for terminal (/~https://github.com/vmware-tanzu/octant/blob/96dd7438f3d1e4a2c4e514238c6b0dcf2d86e4d2/internal/api/terminal_manager.go#L156).
We just need to wait for a bit longer to setup remote connection stream.