Add 'at most' and 'at least' aliases for comparison rules #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkepin
force-pushed
the
add_comparison_rules
branch
2 times, most recently
from
56957c0 to
ed69dc5
Compare
valfirst
requested changes
Feb 14, 2025
| @@ -40,6 +40,14 @@ public <T extends Comparable<T>> Matcher<T> getComparisonRule(T variable) | |||
| return Matchers.lessThanOrEqualTo(variable); | |||
| } | |||
| }, | |||
| AT_MOST("at most") | |||
There was a problem hiding this comment.
Suggested change
| AT_MOST("at most") | |
| AT_MOST("<=") |
?
There was a problem hiding this comment.
this was done to return LESS_THAN_OR_EQUAL_TO value in fromString method for '<=' sign regardless of the order of declaration of elements in enum
There was a problem hiding this comment.
ok, then just add null alias, and add processing of null-s
| @@ -56,6 +64,14 @@ public <T extends Comparable<T>> Matcher<T> getComparisonRule(T variable) | |||
| return Matchers.greaterThanOrEqualTo(variable); | |||
| } | |||
| }, | |||
| AT_LEAST("at least") | |||
There was a problem hiding this comment.
Suggested change
| AT_LEAST("at least") | |
| AT_LEAST(">=") |
?
There was a problem hiding this comment.
| @Override | ||
| public <T extends Comparable<T>> Matcher<T> getComparisonRule(T variable) | ||
| { | ||
| return Matchers.lessThanOrEqualTo(variable); |
There was a problem hiding this comment.
Suggested change
| return Matchers.lessThanOrEqualTo(variable); | |
| return ComparisonRule.LESS_THAN_OR_EQUAL_TO.getComparisonRule(variable); |
| @Override | ||
| public <T extends Comparable<T>> Matcher<T> getComparisonRule(T variable) | ||
| { | ||
| return Matchers.greaterThanOrEqualTo(variable); |
There was a problem hiding this comment.
Suggested change
| return Matchers.greaterThanOrEqualTo(variable); | |
| return ComparisonRule.GREATER_THAN_OR_EQUAL_TO.getComparisonRule(variable); |
Comment on lines
51
to
58
| Then `${details.networkState}` is at least `1` | ||
| Then `${details.src}` matches `.+/video/countdown\.mp4` | ||
| When I play video in video player located by `<videoLocator>` | ||
| Then element located by `<videoLocator>` exists for `PT1S` duration | ||
| When I save info from video player located by `<videoLocator>` to SCENARIO variable `details` | ||
| Then `${details.currentTime}` is > `${rewindTime}` | ||
| Then `${details.duration}` is > `8` | ||
| Then `${details.networkState}` is >= `1` | ||
| Then `${details.networkState}` is at least `1` |
There was a problem hiding this comment.
this doesn't have much sense logically, it's better to change some tests from DynamicVariablesTests.story
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5726 +/- ##
=========================================
Coverage 97.73% 97.73%
- Complexity 7177 7179 +2
=========================================
Files 993 993
Lines 20823 20825 +2
Branches 1365 1366 +1
=========================================
+ Hits 20351 20353 +2
Misses 362 362
Partials 110 110 ☔ View full report in Codecov by Sentry. |
vkepin
force-pushed
the
add_comparison_rules
branch
from
ed69dc5 to
f198d8b
Compare
vkepin
force-pushed
the
add_comparison_rules
branch
from
6262469 to
435c88c
Compare
valfirst
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.