-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views: VTGate changes for seamless integration #17439
Open
harshit-gangal
wants to merge
6
commits into
vitessio:main
Choose a base branch
from
planetscale:views-vtgate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 26, 2024
harshit-gangal
changed the title
views: default on for VTGate
Views: VTGate changes for seamless integration
Dec 26, 2024
harshit-gangal
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 26, 2024
harshit-gangal
force-pushed
the
views-vtgate
branch
from
December 27, 2024 05:24
6fe32dd
to
43c8519
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17439 +/- ##
==========================================
+ Coverage 67.68% 67.70% +0.01%
==========================================
Files 1584 1584
Lines 254630 254786 +156
==========================================
+ Hits 172356 172497 +141
- Misses 82274 82289 +15 ☔ View full report in Codecov by Sentry. |
7 tasks
harshit-gangal
removed
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
NeedsWebsiteDocsUpdate
What it says
labels
Jan 9, 2025
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… not required Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
views-vtgate
branch
from
January 9, 2025 17:07
43cc0f5
to
43718a4
Compare
harshit-gangal
requested review from
systay,
frouioui,
GuptaManan100,
arthurschreiber and
deepthi
as code owners
January 9, 2025 17:07
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates view support to seamlessly integrate with VTGate when the “enable-views” flag is default-on.
It unifies the logic for creating, altering, and dropping views.
Additional tests are unnecessary, as existing tests should continue to validate the unified logic.
Related Issue(s)
Checklist
Deployment Notes