fix(ssr-react): remove context
from render
#276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #227
The example seems not to be using "Data Router". In that case, we only provide
location
withoutcontext
to<StaticRouter />
. Therefore, I just removedcontext
out of the files regarding it.If it needs an example with "Data Router", I can add one. However, since
react-router
usesvite
, I don't think the example won't be so much different than thereact-router
one.So the bottom line is:
react-router
's repositoryAdditional context
I would like to add some tests around RSC, however because
react-router
only supportloader
pattern ofremix
, not the RSC, it won't be easy.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).