Fix #568: loading the tabs module failed #675
Conversation
| return [row._folder for ([row] in this.getAllFolderRowMap(true,true)) if (row._folder.flags & flag)] | ||
| return Array.from(this.getAllFolderRowMap(true, true), ([row]) => row) | ||
| .filter(row => row._folder.flags & flag) | ||
| .map(row => row._folder); |
There was a problem hiding this comment.
more short method chains: Array.from(<generator>, ([row]) => row._folder).filter(folder => folder.flags & flag)
ma8ma
force-pushed
the
update-generator-function
branch
from
5d417ea to
4a763f2
Compare
|
I'm not qualified to review this, but I want to thank @ma8ma for the work and hope to see a release with this soon ❤️ 😁 |
| for (let [, row] in Iterator(children)) { | ||
| let folder = row._folder; | ||
| let folderString = prefix + "/" + | ||
| (row.useServerNameOnly ? folder.server.prettyName : folder.abbreviatedName); | ||
| yield [row, folderString]; | ||
| if (row.children.length > 0) | ||
| for (let child in walkChildren(row.children, folderString)) | ||
| for (let child of walkChildren(row.children, folderString)) | ||
| yield child; |
There was a problem hiding this comment.
unnecessary for of loop, can delegate using yield* walkChildren(...);
ma8ma
force-pushed
the
update-generator-function
branch
from
4a763f2 to
35e51c5
Compare
| completer: function (context) [[s.key, s.serverURI] for ([, s] in Iterator(mail.smtpServers))], | ||
| completer: function (context) { | ||
| return Array.from((function* () { | ||
| for (let [, s] in Iterator(mail.smtpServers)) |
There was a problem hiding this comment.
Why keep the old in Iterator(...)?
There was a problem hiding this comment.
Sure, smtpServers property is Array type, therefore, can simplify to replace with return mail.smtpServers.map(s => [s.key, s.serverURI]);
| * in the current window. | ||
| */ | ||
| get browsers() { | ||
| browsers: function* () { |
There was a problem hiding this comment.
Could have kept the getter by returning the result of an additional generator function. I am not sure which way is best.
There was a problem hiding this comment.
Yeah. browsers can create generator within property to keep getter, I'm going to try.
* Replace legacy generator with ES2015 generator for almost places. * Replace non-standard Array comprehension with Array methods in muttator/content/mail.js. Several legacy generators still keep because they have been handled by legacy iterators: * iter() in common/content/base.js * callbacks of addPageInfoSection() in common/content/buffer.js * evaluateXPath() in common/content/util.js * range() in common/content/util.js * itervalues() in common/content/util.js * iteritems() in common/content/util.js
ma8ma
force-pushed
the
update-generator-function
branch
from
35e51c5 to
c76a292
Compare
|
Thank you so much for this patch. Sorry for the delay, but I wasn't able to test this myself until now. I'd also like to reiterate for anyone reading this that Vimperator is (and has been for some time) in need for contributors. This specific issue has been known since Firefox 51 was nightly (August 2016). Looking at all the (breaking) changes Mozilla keeps pushing, this certainly will not be the last time. Please see the following links for more information:
Until a new release has been made, submitted to AMO and finally approved by Mozilla, users will have to build their own versions. Either go for an unbranded release of Firefox (which allows |
|
@timss First of all, my thanks to you and @gkatsev for keeping Vimperator alive. Despite the complaints, I'm grateful that the maintainers do respond and update AMO when needed, even if it's not always timely.
Wouldn't it help if this was made more obvious with a notice on vimperator.org and in the README here? |
|
@brianpeiris thanks. I'll make sure to make a note on the AMO page about wanting contributors. @maxauthority would you be able to update the website? |
This PR makes to fix #568 loading the tabs module (see also the candidate).
Several legacy generators still keep because they have been handled by legacy iterators.