Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check and error message for undefined techs #1210

Closed
wants to merge 2 commits into from
Closed

Added check and error message for undefined techs #1210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93479cd
Added check and error message for undefined techs
dominic-p May 14, 2014
58484ed
Fixed trailing whitespace
dominic-p May 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/js/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,12 @@ vjs.Player.prototype.selectSource = function(sources){
var techName = vjs.capitalize(j[i]),
tech = window['videojs'][techName];

// Check if the current tech is defined before continuing
if (!tech) {
vjs.log.error('The "' + techName + '" tech is undefined. Skipped browser support check for that tech.');
continue;
}

// Check if the browser supports this technology
if (tech.isSupported()) {
// Loop through each source object
Expand Down