Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix usage of a deprecated Node.js version #1231

Merged
merged 3 commits into from
Nov 18, 2024
Merged

chore(ci): fix usage of a deprecated Node.js version #1231

merged 3 commits into from
Nov 18, 2024

Conversation

hamirmahal
Copy link
Contributor

Fixes #1230

hamirmahal
hamirmahal commented Nov 17, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
styfle
styfle requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please revert all the whitespace changes so its clear what is changing. Changes to formatting can happen in a different PR than code changes.

@hamirmahal hamirmahal closed this Nov 18, 2024
@hamirmahal hamirmahal reopened this Nov 18, 2024
@hamirmahal
Copy link
Contributor Author

You're welcome!

I reverted the changes from formatting on save.

styfle
styfle reviewed Nov 18, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@styfle styfle changed the title fix: usage of a deprecated Node.js version chore(ci): fix usage of a deprecated Node.js version Nov 18, 2024
@styfle styfle enabled auto-merge (squash) November 18, 2024 21:06
@styfle styfle merged commit 2d6cb2f into vercel:main Nov 18, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Awaiting requested review from Timer Timer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci.yml uses a deprecated Node.js version
2 participants
@hamirmahal @styfle