chore: Add upper version bound on VegaFusion #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
changed the title
dangotbanned
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Seems like a good idea to me, thanks @jonmmease
We should probably consider setting upper bounds more often.
I was planning to suggest some changes to fix the # type: ignore, but realised that it ended up touching 4 other files.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is looking ahead toward the future release of VegaFusion 2. It adds an upper version bound in the
allgroup, and makes a tweak to how the VegaFusion versions are validated.I'm hoping there won't be breaking changes wrt to Altair's usage of VegFusion, but want to be safe.
VegaFusion 2 will only have a single Python package named VegaFusion (
vegafusion-python-embedwill be no more). If I can make things backward compatible, I'll patch things so that callingimportlib_version("vegafusion-python-embed")will return the same version asimportlib_version("vegafusion")so that our validation passes. To make this possible in the future, I moved the vegafusion import above these checks.