Simplify dependencies #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the "memoffset" dependency and replaced it with #![feature(offset_of)]
Removed the "once_cell" dependency and replaced it with #![feature(once_cell_try)]
#[stable(feature = "once_cell", since = "1.70.0")]
veeenu
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the "once_cell" dependency and replaced it with #![feature(once_cell_try)]
Removed the "memoffset" dependency and replaced it with #![feature(offset_of)]
#[stable(feature = "once_cell", since = "1.70.0")]
#[unstable(feature = "offset_of", issue = "106655")]
rust-lang/rust#106655
Did a simple test
1.71.0-nightly
once_cell = "1.8.0"
Debug
std::sync::OnceLock time: 1.8730884s
once_cell::sync::OnceCell time: 4.1763288s
Release
std::sync::OnceLock time: 47.0772ms
once_cell::sync::OnceCell time: 47.0337ms