Fixed typings.

vazco · Jan 19, 2021 · be843c7 · be843c7
1 parent 8645ac1
commit be843c7
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 12 deletions.
diff --git a/packages/uniforms-antd/__tests__/SelectField.tsx b/packages/uniforms-antd/__tests__/SelectField.tsx
@@ -275,9 +275,11 @@ test('<SelectField> - disabled items (options) based on predicate', () => {
     }),
   );
 
-  expect(wrapper.find(Select).prop('children')).toHaveLength(2);
-  expect(wrapper.find(Select).prop('children')[0].props.disabled).toBe(true);
-  expect(wrapper.find(Select).prop('children')[1].props.disabled).toBe(false);
+  // FIXME: The `children` prop is not indexable on its own.
+  const children: any = wrapper.find(Select).prop('children');
+  expect(children).toHaveLength(2);
+  expect(children[0].props.disabled).toBe(true);
+  expect(children[1].props.disabled).toBe(false);
 });
 
 test('<SelectField checkboxes> - renders a set of checkboxes', () => {

diff --git a/packages/uniforms-antd/src/BoolField.tsx b/packages/uniforms-antd/src/BoolField.tsx
@@ -14,8 +14,7 @@ export type BoolFieldProps = FieldProps<
   {
     checkbox?: boolean;
     checkedChildren?: ReactNode;
-    // FIXME: `Switch` is a value and exporting `typeof Switch` type is impossible.
-    inputRef?: Ref<Checkbox | typeof Switch | any>;
+    inputRef?: Ref<typeof Checkbox | typeof Switch | any>;
     unCheckedChildren?: ReactNode;
   }
 >;

diff --git a/packages/uniforms-antd/src/ListDelField.tsx b/packages/uniforms-antd/src/ListDelField.tsx
@@ -15,7 +15,7 @@ function ListDel({
   disabled,
   icon = <DeleteOutlined />,
   name,
-  shape = 'circle-outline',
+  shape = 'circle',
   size = 'small',
   type = 'ghost',
   ...props

diff --git a/packages/uniforms-antd/src/LongTextField.tsx b/packages/uniforms-antd/src/LongTextField.tsx
@@ -1,4 +1,4 @@
-import TextArea, { TextAreaProps } from 'antd/lib/input/TextArea';
+import TextArea, { TextAreaProps, TextAreaRef } from 'antd/lib/input/TextArea';
 import React, { Ref } from 'react';
 import { FieldProps, connectField, filterDOMProps } from 'uniforms';
 
@@ -8,7 +8,7 @@ export type LongTextFieldProps = FieldProps<
   string,
   // FIXME: Why `onReset` fails with `wrapField`?
   Omit<TextAreaProps, 'onReset'>,
-  { inputRef?: Ref<TextArea> }
+  { inputRef?: Ref<TextAreaRef> }
 >;
 
 function LongText({ rows = 5, ...props }: LongTextFieldProps) {

diff --git a/packages/uniforms-antd/src/SelectField.tsx b/packages/uniforms-antd/src/SelectField.tsx
@@ -17,7 +17,7 @@ type CheckboxesProps = FieldProps<
     allowedValues?: CheckboxValueType[];
     checkboxes: true;
     disableItem?(value: CheckboxValueType): boolean;
-    inputRef?: Ref<CheckboxGroup | typeof RadioGroup>;
+    inputRef?: Ref<typeof CheckboxGroup | typeof RadioGroup>;
     required?: boolean;
     transform?(value: CheckboxValueType): string;
   }
@@ -30,7 +30,7 @@ type SelectProps = FieldProps<
     allowedValues?: string[];
     checkboxes?: false;
     disableItem?(value: CheckboxValueType): boolean;
-    inputRef?: Ref<SelectAntD<string | string[]>>;
+    inputRef?: Ref<typeof SelectAntD>;
     required?: boolean;
     transform?(value: string): string;
   }
@@ -43,6 +43,7 @@ function Select(props: SelectFieldProps) {
   return wrapField(
     props,
     props.checkboxes ? (
+      // @ts-ignore: Incorrect `value` type.
       <Group
         disabled={props.disabled}
         name={props.name}
@@ -65,10 +66,10 @@ function Select(props: SelectFieldProps) {
         allowClear={!props.required}
         disabled={props.disabled}
         mode={props.fieldType === Array ? 'multiple' : undefined}
-        // @ts-ignore: There's no `name` property on Select?
         name={props.name}
         onChange={value => props.onChange(value)}
         placeholder={props.placeholder}
+        // @ts-ignore: Incorrect `inputRef` type.
         ref={props.inputRef}
         value={
           props.fieldType === Array

diff --git a/packages/uniforms/__tests__/BaseForm.tsx b/packages/uniforms/__tests__/BaseForm.tsx
@@ -255,7 +255,8 @@ describe('BaseForm', () => {
     });
 
     it('sets `submitting` state while submitting', async () => {
-      let resolveSubmit = () => {};
+      // FIXME: It should say `() => void`.
+      let resolveSubmit: (...args: any[]) => void = () => {};
       wrapper.setProps({
         onSubmit: () => new Promise(resolve => (resolveSubmit = resolve)),
       });