builtin.vcl: Delete Content-Range header where it has no meaning #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
force-pushed
the
builtin_neuter_content-range
branch
from
82aa447 to
bb29f4b
Compare
nigoroll
commented
Aug 12, 2024
Since 4ab1100 (see also varnishcache#3246), we fail backend responses with an unexpected Content-Range. Yet RFC9110 states: The Content-Range header field has no meaning for status codes that do not explicitly describe its semantic. https://www.rfc-editor.org/rfc/rfc9110.html#section-14.4 The semantic is described for status codes 206 and 416, so the obvious implementation change would be for core code to only consider Content-Range for these status codes. But there might be scenarios where a stricter-than-RFC check is intended, so we keep that in core code and change builtin.vcl to remove the header where it has no semantic.
nigoroll
force-pushed
the
builtin_neuter_content-range
branch
from
bb29f4b to
477a5dd
Compare
dridi
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4ab1100 (see also #3246), we fail backend responses with an unexpected
Content-Range.Yet RFC9110 states:
The semantic is described for status codes 206 and 416, so the obvious implementation change would be for core code to only consider
Content-Rangefor these status codes.But there might be scenarios where a stricter-than-RFC check is intended, so we keep that in core code and change
builtin.vclto remove the header where it has no semantic.