Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure shebang lines are passed through as expected #158

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Ensure shebang lines are passed through as expected #158

merged 1 commit into from
Jan 3, 2025

Conversation

akx
Copy link
Member

@akx akx commented Jan 3, 2025 •
edited
Loading

This PR ensures shebang lines remain as-is when commands are joined together.

Other comments won't be handled correctly by join_commands yet, though.

@akx akx marked this pull request as ready for review January 3, 2025 09:00
@akx akx requested review from a team, teroyks and ruksi and removed request for a team January 3, 2025 09:01
hylje
hylje approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@hylje hylje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asserts expectations, shells can now be banged

@akx akx merged commit 23a5d0e into master Jan 3, 2025
6 checks passed
@akx akx deleted the shebang branch January 3, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hylje hylje hylje approved these changes

@teroyks teroyks Awaiting requested review from teroyks teroyks was automatically assigned from valohai/dev-be

@ruksi ruksi Awaiting requested review from ruksi ruksi was automatically assigned from valohai/dev-be

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @hylje