-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ink-as-dependency
#1163
Remove ink-as-dependency
#1163
Conversation
Without the `ink_as_dependency` feature flag we can't have two definitions of `ink::contract` in the same file (we get conflicts with `__ink_generate_metadata()`, `call()`, and `deploy()` ).
I'll fix the CI tomorrow 😔 |
You can't just remove the @Robbepop mentioned in that #665 the idea with |
Hmm yeah, I figured the So the main thing I really wanted to get rid of here was the I think we can still do that without removing the |
|
Okay so I'm gonna split this out into two PRs.
For (1) I've opened #1168, and for (2) I've started playing around with something today, will |
As part of the
ink!
RC7 release theink!
codegen started generating aContractRef
struct alongside the
Contract
struct. Since then there has been no need forink-as-dependency
because all contracts get a generatedRef
struct which can be usedanywhere
ink-as-dependency
would've been used.The release notes even mention that the
Ref
struct was meant to be the successor to theink-as-dependency
concept.This PR removes
ink-as-dependency
since it is no longer needed.