Merge pull request #68 from unzerdev/develop

Develop
unzerdev · Aug 12, 2024 · fd94958 · fd94958
2 parents e7dcfba + ac58d37
commit fd94958
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.1.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [3.2.1](/~https://github.com/unzerdev/magento2/compare/3.2.0..3.2.1)
+### Fixed
+* missing mandatory cardholder field for cards payment method
+
 ## [3.2.0](/~https://github.com/unzerdev/magento2/compare/3.1.0..3.2.0)
 ### Added
 * TWINT payment method

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "unzerdev/magento2",
     "description": "This extension for Magento 2 provides a direct integration of the Unzer payment types to your Magento 2 shop via the Unzer Payment API (PAPI).",
     "type": "magento2-module",
-    "version": "3.2.0",
+    "version": "3.2.1",
     "license": "Apache-2.0",
     "require": {
         "php": "~7.4.0|~8.1.0|~8.2.0|~8.3.0",

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Unzer_PAPI" setup_version="3.2.0">
+    <module name="Unzer_PAPI" setup_version="3.2.1">
         <sequence>
             <module name="Magento_Checkout"/>
             <module name="Magento_Config" />

diff --git a/view/frontend/web/js/view/payment/method-renderer/cards.js b/view/frontend/web/js/view/payment/method-renderer/cards.js
@@ -14,6 +14,7 @@ define(
                     cvc: {valid: null},
                     expiry: {valid: null},
                     number: {valid: null},
+                    holder: {valid: null},
                 },
                 template: 'Unzer_PAPI/payment/cards'
             },
@@ -44,10 +45,15 @@ define(
                     containerId: 'unzer-card-element-id-cvc',
                     onlyIframe: false
                 });
+                this.resourceProvider.create('holder', {
+                    containerId: 'unzer-card-element-id-holder',
+                    onlyIframe: false
+                });
 
                 this.fields.cvc.valid = ko.observable(false);
                 this.fields.expiry.valid = ko.observable(false);
                 this.fields.number.valid = ko.observable(false);
+                this.fields.holder.valid = ko.observable(false);
 
                 this.resourceProvider.addEventListener('change', function (event) {
                     if ("type" in event) {
@@ -62,7 +68,8 @@ define(
                 return ko.computed(function () {
                     return self.fields.cvc.valid() &&
                         self.fields.expiry.valid() &&
-                        self.fields.number.valid();
+                        self.fields.number.valid() &&
+                        self.fields.holder.valid();
                 })();
             },
 

diff --git a/view/frontend/web/template/payment/cards.html b/view/frontend/web/template/payment/cards.html
@@ -28,6 +28,9 @@
                     <div id="unzer-card-element-id-cvc" class="unzerInput"></div>
                 </div>
             </div>
+            <div class="field">
+                <div id="unzer-card-element-id-holder" class="unzerInput"></div>
+            </div>
             <!-- ko if: (isVaultEnabled())-->
                 <div class="field">
                     <div class="unzerUI checkbox">