fix: skia+wasm shadow-container hitbox #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1292.eastus2.azurestaticapps.net |
kazo0
approved these changes
Nov 27, 2024
nickrandolph
approved these changes
Nov 27, 2024
|
@Mergifyio backport release/stable/6.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit 71fc2e4)
13 tasks
kazo0
pushed a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1139, closes #1184
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On skia and wasm, the hitbox of ShadowContainer is much larger than its visual/content (depending on the shadows used), often prevent neighboring elements from receiving pointer events.
What is the new behavior?
The shadow layer is now
IsHitTestVisible=False, and no longer interferes with clickability of neighboring elements.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
from observation, this issue seems to only impact skia and wasm. windows, android and ios are unaffected.