-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax <lib> requirement to include a dict #173
base: gh-pages
Are you sure you want to change the base?
Conversation
Cf. fonttools/fonttools#2234 I think it's too strict to require a <dict>. An empty <lib /> should be OK. Also, there's a grammatical error in the sentence, which I fixed.
Counterpoint: a |
Thinking about the above: I part of this comes down to if one things that an empty |
I think they're the same. |
In this case an empty The only real questions I see here are: a) How to handle UFO versioning and backwards compatibility. |
On the one hand, I don't see any semantical difference between an empty |
I don't know @ctrlcctrlv's use case either but the obvious one that occurs to me is using XML libraries to serialize data structures where you don't get a choice on how this is output. Which is also why normalization is a touchy subject. Unilaterally declaring that one way of representing this particular noop as right and the others wrong is not that much different from saying the XML has to be indented with tabs instead of spaces. I have strong opinions about which one is best, but not everybody has the luxury of doing it "my" way. |
whatever. I'm ok with relaxing that restriction. It does not have any backward compatibility issues, because compliant implementations already support the current stricter requirement. |
drop it |
on second thought, this does have backward compatibility concerns. In which case, it's not really worth it. |
... or can be pushed back to UFO4 |
What are the backwards compatibility concerns? |
If one tool (e.g. yours) emits such empty libs, and another tool that was working for current UFO3 fails because expects a lib to contain a child |
Oh yeah, OK. I'm perfectly fine with pushing this to UFO4, by the way. MFEK is, in general, on a similar very long timeline. The glyph editor will probably be mostly done by the end of the year, but it's an ambitious effort. Won't be built in a day. Especially my days, what with the disability and all. |
Cf. fonttools/fonttools#2234
I think it's too strict to require a . An empty should be OK. Also, there's a grammatical error in the sentence, which I fixed.